Clean up DD Axes #8829
Clean up DD Axes #8829
Conversation
ianna
commented
Apr 22, 2015
ianna
commented
- Use strongly-typed enum
- Use range-based for loop
- Remove index
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar |
|
@cmsbuild, please test |
|
The tests are being triggered in jenkins. |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar |
|
-1 |
cmsbuild
added
comparison-pending
fully-signed
and removed
comparison-pending
fully-signed
geometry-approved
orp-pending
tests-started
labels
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes (but tests are reportedly failing). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar |
|
@cmsbuild - the error is in DAS - unrelated to this PR. |
|
-1 Tested at: 2681e03 ---> test testRecoMETMETProducers had ERRORS you can see the results of the tests here: |
|
@cmsbuild - ok, the unit test fails due to another reason. Though, I can fix it in this PR. |
|
Comparison is ready The workflows 140.53 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes (but tests are reportedly failing). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar |
