Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINIAOD BUGFIX: pvREF not set for some electrons #8843

Merged

Conversation

arizzi
Copy link
Contributor

@arizzi arizzi commented Apr 23, 2015

Electron pfCandidates with gsfTracks but without a generalTrack are not associated to PVs in MINIAOD.
The fix tests both gsfTracks and regular tracks for all PFCandidates (preferring the gsfTrack when both available)

same as #8842

@gpetruc

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @arizzi for CMSSW_7_4_X.

MINIAOD BUGFIX: pvREF not set for some electrons

It involves the following packages:

CommonTools/RecoAlgos
PhysicsTools/PatAlgos

@nclopezo, @cvuosalo, @monttj, @cmsbuild, @slava77, @vadler can you please review it and eventually sign? Thanks.
@rappoccio, @jdolen, @imarches, @makortel, @acaudron, @abbiendi, @mmarionncern, @jhgoh, @ahinzmann, @nhanvtran, @schoef, @ferencek, @mariadalfonso, @pvmulder, @TaiSakuma this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

Pull request #8843 was updated. @nclopezo, @cvuosalo, @monttj, @cmsbuild, @slava77, @vadler can you please check and sign again.

@slava77
Copy link
Contributor

slava77 commented Apr 23, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@slava77
Copy link
Contributor

slava77 commented Apr 23, 2015

+1

for #8843 2db0a1b
the same topic branch as #8842 2db0a1b
signed off based on review in #8842

@davidlange6
Copy link
Contributor

+1

davidlange6 added a commit that referenced this pull request Apr 23, 2015
MINIAOD BUGFIX: pvREF not set for some electrons
@davidlange6 davidlange6 merged commit 25d04e9 into cms-sw:CMSSW_7_4_X Apr 23, 2015
@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8843/4367/summary.html

The workflows 140.53, 4.53 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants