Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

correct some InputTags for track collections #8866

Closed
wants to merge 1 commit into from
Closed

correct some InputTags for track collections #8866

wants to merge 1 commit into from

Conversation

lveldere
Copy link
Contributor

  • replaced some inputtags for the non-existing collection "hltIter2HighPtTkMuMerged" with "generalTracks"
  • grepped through all Famos menus for "hltIter2HighPtTkMuMerged" and corrected accordingly
  • updated confdb.py accordingly
  • tested with runTheMatrix -l 135.1

@lveldere
Copy link
Contributor Author

please test

@cmsbuild cmsbuild added this to the Next CMSSW_7_5_X milestone Apr 24, 2015
@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @lveldere for CMSSW_7_5_X.

correct some InputTags for track collections

It involves the following packages:

HLTrigger/Configuration

@Martin-Grunewald, @perrotta, @cmsbuild, @nclopezo, @fwyzard can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @geoff-smith, @jalimena this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@Martin-Grunewald
Copy link
Contributor

-1
sorry, i have to do this properly via confb and dump extraction...

@lveldere
Copy link
Contributor Author

@Martin-Grunewald

As you wish.
Has it any consequence that I don't understand, going via confb and dump extraction?
Or is it just to be absolutely sure that everything is in the right place?

@cmsbuild
Copy link
Contributor

-1
Tested at: 01bca10
When I ran the RelVals I found an error in the following worklfows:
1306.0 step3

runTheMatrix-results/1306.0_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15+MINIAODMCUP15/step3_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15+MINIAODMCUP15.log

1330.0 step3

runTheMatrix-results/1330.0_ZMM_13+ZMM_13+DIGIUP15+RECOUP15+HARVESTUP15+MINIAODMCUP15/step3_ZMM_13+ZMM_13+DIGIUP15+RECOUP15+HARVESTUP15+MINIAODMCUP15.log

25202.0 step3

runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25+MINIAODMCUP15/step3_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25+MINIAODMCUP15.log

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8866/4376/summary.html

Martin-Grunewald
Martin-Grunewald reviewed Apr 24, 2015
View reviewed changes
HLTrigger/Configuration/python/Tools/confdb.py
@@ -456,6 +456,7 @@ def fixForFastSim(self):
self._fix_parameter(name = 'src', type = 'InputTag', value = 'hltHcalTowerNoiseCleaner', replace = 'hltTowerMakerForAll')

# input tags for track collections
self._fix_parameter( type = 'InputTag', value = 'hltIter2HighPtTkMuMerged', replace = 'generalTracks')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is already there (few lines down).

@Martin-Grunewald
Copy link
Contributor

Please see #8867

@lveldere
Copy link
Contributor Author

@Martin-Grunewald
I understood correctly that you take this over in #8867?

@lveldere lveldere closed this Apr 24, 2015
@Martin-Grunewald
Copy link
Contributor

@lveldere
Yes.
(It seems I had simply forgotten a commit after a change, as confdb.py is unchanged.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-pending hlt-rejected orp-pending pending-signatures tests-rejected
Projects
None yet
Milestone
CMSSW_7_5_X
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lveldere @cmsbuild @Martin-Grunewald