Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various fixes for ConddbEssource input parameters handling #8885

Merged

Conversation

ggovi
Copy link
Contributor

@ggovi ggovi commented Apr 27, 2015

This PR include:

  • A Warning message is printed when a GT ora a Tag are read from a production V1 account
  • A clean up of the handling of DB ESSource input parameters from cfg
  • A fix to support '@' character(s) in sqlite file names

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ggovi for CMSSW_7_5_X.

Various fixes for ConddbEssource input parameters handling

It involves the following packages:

CondCore/CondDB
CondCore/ESSources

@diguida, @cerminar, @cmsbuild, @nclopezo, @ggovi, @mmusich can you please review it and eventually sign? Thanks.
@ghellwig, @apfeiffer1 this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@ggovi
Copy link
Contributor Author

ggovi commented Apr 27, 2015

+1

@diguida
Copy link
Contributor

diguida commented Apr 27, 2015

@cmsbuild
please test

@cmsbuild
Copy link
Contributor

-1
Tested at: 6baffcf
When I ran the RelVals I found an error in the following worklfows:
25202.0 step2

runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25+MINIAODMCUP15/step2_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25+MINIAODMCUP15.log
----- Begin Fatal Exception 27-Apr-2015 13:49:37 CEST-----------------------
An exception of category 'Configuration' occurred while
   [0] Processing run: 1 lumi: 1 event: 1
   [1] Running path 'digitisation_step'
   [2] Calling event method for module MixingModule/'mix'
Exception Message:
RootInputFileSequence::readOneRandom(): no input files specified for secondary input source.
----- End Fatal Exception -------------------------------------------------

50202.0 step2

runTheMatrix-results/50202.0_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50+MINIAODMCUP1550/step2_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50+MINIAODMCUP1550.log
----- Begin Fatal Exception 27-Apr-2015 13:50:31 CEST-----------------------
An exception of category 'Configuration' occurred while
   [0] Processing run: 1 lumi: 1 event: 1
   [1] Running path 'digitisation_step'
   [2] Calling event method for module MixingModule/'mix'
Exception Message:
RootInputFileSequence::readOneRandom(): no input files specified for secondary input source.
----- End Fatal Exception -------------------------------------------------

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8885/7330/summary.html

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8885/5176/summary.html

The workflows 140.53 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

return -1


from Configuration.AlCa.autoCond import aliases
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ggovi this should be changed to

from Configuration.AlCa.autoCond_condDBv1 import aliases

@mmusich mmusich mentioned this pull request Jul 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants