Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GEM-CSC integrated local trigger (part I) #8890

Merged
merged 33 commits into from Jun 18, 2015
Merged

GEM-CSC integrated local trigger (part I) #8890

merged 33 commits into from Jun 18, 2015

Conversation

dildick
Copy link
Contributor

@dildick dildick commented Apr 28, 2015

This PR includes changes in L1Trigger/CSCTriggerPrimitives due to the GEM-CSC trigger port (from 62X SLHC)

  • GEMCSCLCTDigi is a new dataformat which will contain the GEM-CSC bending angle - until we know how the bending will be used by the CSC TrackFinder
  • Assignment of bending is currently disabled; will be enabled soon.
  • Integrated local triggers are by default disabled
  • All untracked parameters are now tracked

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @dildick (Sven Dildick) for CMSSW_7_5_X.

Changes due to GEM-CSC trigger

It involves the following packages:

DataFormats/CSCDigi
L1Trigger/CSCTriggerPrimitives

@cmsbuild, @civanch, @nclopezo, @mulhearn, @mdhildreth can you please review it and eventually sign? Thanks.
@valuev, @Martin-Grunewald this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

@dildick - sorry for my slow review here - but I had a generic question - in other PRs we had CSC dependencies in GEM packages (eg, new code depends on old) - here it seems to be the reverse - that we've added GEM dependencies in CSC packages. Is this design discussed and agreed / needed?

@dildick
Copy link
Contributor Author

dildick commented Jun 17, 2015

It was approved by Tim Cox.

@davidlange6
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants