Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SimVertexs collection for FastTiming studies #8891

Conversation

simonepigazzini
Copy link
Contributor

Adding SimVertex collection for interaction vertices only (PU+Signal), the collection are produced as a slimmer version of the CrossingFrame transient collection. This PR addresses the memory issues of the default CFWriter module collections.

@amartelli

arabella and others added 2 commits April 24, 2015 17:07
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @simonepigazzini for CMSSW_6_2_X_SLHC.

SimVertexs collection for FastTiming studies

It involves the following packages:

Configuration/Applications
Configuration/StandardSequences
SimGeneral/MixingModule

@civanch, @nclopezo, @mdhildreth, @cmsbuild, @franzoni, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @Martin-Grunewald, @wmtan, @makortel, @GiacomoSguazzoni, @rovere, @VinInn, @appeltel, @cerati, @dgulhan this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@fratnikov, @mark-grimes you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

-1

Tested at: 391122d
I found errors in the following unit tests:

---> test TestConfigDP had ERRORS

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8891/4420/summary.html

@cmsbuild
Copy link
Contributor

-1

Tested at: 391122d
I found errors in the following unit tests:

---> test TestConfigDP had ERRORS

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8891/4440/summary.html

@simonepigazzini
Copy link
Contributor Author

compiling with 'scram b runtests' locally does not show any error

@fratnikov
Copy link

@simonepigazzini The problem can be reproduced with (C-shell):
setenv LOCAL_TEST_DIR $CMSSW_RELEASE_BASE/src/Configuration/DataProcessing/test
$CMSSW_RELEASE_BASE/src/Configuration/DataProcessing/test/run_CfgTest.sh

@fratnikov
Copy link

Looks like the problem is not related to this PR

@davidlange6
Copy link
Contributor

the unit test is also failing in the integration build - so indeed, its failure is unrelated.

On Apr 29, 2015, at 10:23 PM, Fedor Ratnikov notifications@github.com wrote:

Looks like the problem is not related to this PR


Reply to this email directly or view it on GitHub.

@mark-grimes
Copy link

Just to update this PR with details discussed in private mail:
There is a big memory leak when reloading crossing frames from disk. We are currently investigating doing the FastTimer studies using the TrackingVertex class instead of using SimVertex in CrossingFrames. If this bears fruit this PR will be obsolete. I propose keeping it open until we know that works though.

@mark-grimes
Copy link

@simonepigazzini, you can close this now. The required changes were introduced with #8975 and #8979.

@simonepigazzini
Copy link
Contributor Author

thanks @mark-grimes. closing now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants