Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fastsim: 74X premixing: activate branches in MixingModule #8902

Closed
wants to merge 2 commits into from
Closed

Fastsim: 74X premixing: activate branches in MixingModule #8902

wants to merge 2 commits into from

Conversation

lveldere
Copy link
Contributor

backport of #8608

rebasing after #8901 gets merged,
will remove the changes to the DataMixer from this pr.

@lveldere
Copy link
Contributor Author

please test

@cmsbuild cmsbuild added this to the Next CMSSW_7_4_X milestone Apr 28, 2015
@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @lveldere for CMSSW_7_4_X.

Fastsim: 74X premixing: activate branches in MixingModule

It involves the following packages:

SimGeneral/DataMixingModule
SimGeneral/MixingModule

@cmsbuild, @civanch, @nclopezo, @mdhildreth can you please review it and eventually sign? Thanks.
@wmtan this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

@lveldere
Copy link
Contributor Author

closing this until decided how/when to backport exactly

@lveldere lveldere closed this Apr 29, 2015
@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8902/4445/summary.html

The workflows 140.53 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants