Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add accessors to SubProcess #8905

Merged
merged 1 commit into from Apr 30, 2015

Conversation

Dr15Jones
Copy link
Contributor

We needed a way to access the Process held by the SubProcess in order for CRAB to fully probe a configuration.

We needed a way to access the Process held by the SubProcess in order for CRAB to fully probe a configuration.
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_5_X.

Add accessors to SubProcess

It involves the following packages:

FWCore/ParameterSet

@cmsbuild, @Dr15Jones, @ktf, @nclopezo can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @wddgit, @wmtan this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@Dr15Jones
Copy link
Contributor Author

please test

@Dr15Jones
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @smuzaffar

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @smuzaffar

@cmsbuild
Copy link
Contributor

-1
Tested at: 750b651
I found a compilation error while trying to compile with clang:
I used this command:
scram b vclean && scram build -k -j 8 USER_CXXFLAGS='-fsyntax-only' COMPILER='llvm compile'

27 warnings generated.
>> Compiling edm plugin /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_5_X_2015-04-28-1100/src/FWCore/Integration/test/ESTestProducers.cc 
>> Compiling edm plugin /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_5_X_2015-04-28-1100/src/FWCore/Integration/test/ESTestAnalyzers.cc 
>> Compiling edm plugin /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_5_X_2015-04-28-1100/src/FWCore/Integration/test/WhatsItWatcherAnalyzer.cc 
>> Compiling edm plugin /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_5_X_2015-04-28-1100/src/FWCore/Integration/test/WhatsIt.cc 
/build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_5_X_2015-04-28-1100/src/FWCore/Integration/test/AssociationMapProducer.cc:80:29: error: unused variable 'vint2' [-Werror,-Wunused-variable]
    std::vector const& vint2 = *inputCollection2;
                            ^
/build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_5_X_2015-04-28-1100/src/FWCore/Integration/test/AssociationMapProducer.cc:76:29: error: unused variable 'vint1' [-Werror,-Wunused-variable]
    std::vector const& vint1 = *inputCollection1;
                            ^


you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8905/4433/summary.html

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes (but tests are reportedly failing). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @smuzaffar

@Dr15Jones
Copy link
Contributor Author

The errors are unrelated to the pull request.

@cmsbuild
Copy link
Contributor

-1
Tested at: 750b651
I found a compilation error while trying to compile with clang:
I used this command:
scram b vclean && scram build -k -j 24 USER_CXXFLAGS='-fsyntax-only' COMPILER='llvm compile'

    int    theDebugLevel;
           ^
1 warning generated.
>> Compiling edm plugin /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_5_X_2015-04-28-2300/src/FWCore/Modules/src/EventAuxiliaryHistoryProducer.cc 
>> Compiling edm plugin /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_5_X_2015-04-28-2300/src/FWCore/Modules/src/EventContentAnalyzer.cc 
/build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_5_X_2015-04-28-2300/src/FWCore/Integration/test/AssociationMapProducer.cc:76:29: error: unused variable 'vint1' [-Werror,-Wunused-variable]
    std::vector const& vint1 = *inputCollection1;
                            ^
/build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_5_X_2015-04-28-2300/src/FWCore/Integration/test/AssociationMapProducer.cc:80:29: error: unused variable 'vint2' [-Werror,-Wunused-variable]
    std::vector const& vint2 = *inputCollection2;
                            ^


you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8905/8700/summary.html

@Dr15Jones
Copy link
Contributor Author

The tests fail because of code already in the release.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8905/8700/summary.html

The workflows 140.53 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes (but tests are reportedly failing). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @smuzaffar

davidlange6 added a commit that referenced this pull request Apr 30, 2015
@davidlange6 davidlange6 merged commit 5bc9523 into cms-sw:CMSSW_7_5_X Apr 30, 2015
@Dr15Jones Dr15Jones deleted the addAccessorsToSubProcess branch August 14, 2015 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants