Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handler order #8932

Merged
merged 3 commits into from May 1, 2015
Merged

Conversation

bbockelm
Copy link
Contributor

@bbockelm bbockelm commented May 1, 2015

Apparently, when a file open error occurs in a built-in TFile plugin, we get a SIGABRT with the dreaded "terminate called after throwing an instance of...". (To reproduce, simply try to open a file named "dcap://dcache-cms-dcap.desy.de//pnfs/desy.de/cms/tier2/store/foo/bar" without this PR).

I wasn't able to figure that one out, however. I did figure out the regression in the ROOT6 branch that caused TFileAdaptor to not be used for dCap; fixed in this PR.

Without it impossible to open files in CMSSW with ROOTDBEUG>0.
Initial TFile plugin loading appears to occur much later in ROOT6;
TFileAdaptor's plugin list was being overridden with the default
plugins when the directory is scanned.  Now, we scan the directory
before TFileAdaptor adds its plugins.

Because the default plugins get loaded earlier, we must make the
xrootd regex match ROOT6's.
prior behavior).  This allows lazy-download to keep working with
HTTP.

Note I let the s3:// protocol default to the ROOT6 plugin.
@cmsbuild
Copy link
Contributor

cmsbuild commented May 1, 2015

A new Pull Request was created by @bbockelm (Brian Bockelman) for CMSSW_7_4_X.

Fix handler order

It involves the following packages:

FWCore/Services
IOPool/TFileAdaptor

@cmsbuild, @Dr15Jones, @nclopezo can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @wddgit, @wmtan this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

davidlange6 added a commit that referenced this pull request May 1, 2015
@davidlange6 davidlange6 merged commit d60afbf into cms-sw:CMSSW_7_4_X May 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants