Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to save initial vertex collection (forward port of #8975) #8989

Merged
merged 2 commits into from May 8, 2015

Conversation

mark-grimes
Copy link

This was an option added to 6_2_X_SLHC to save a TrackingVertex collection of just the initial interactions for each signal and pileup event. This was required for fast timing studies. I'm not sure how useful this would be in 75X but I thought I'd submit the PR and let you decide. More details on #8975.

The option is off by default, to turn in it on requires

process.mix.digitizers.mergedtruth.createInitialVertexCollection = True
process.FEVTDEBUGHLToutput.outputCommands.append('keep TrackingVertexs_mix_InitialVertices_*')

added to the digi config file. If on then at 0 pileup it adds 2980.5 bytes/event uncompressed, 695.2 bytes/event compressed (using workflow 38.0). The figure quoted on #8975 is for 140 pileup, I'd expect it to be roughly proportional to pileup.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 7, 2015

A new Pull Request was created by @mark-grimes (Mark Grimes) for CMSSW_7_5_X.

Add option to save initial vertex collection (forward port of #8975)

It involves the following packages:

SimGeneral/MixingModule
SimGeneral/TrackingAnalysis

@cmsbuild, @civanch, @nclopezo, @mdhildreth can you please review it and eventually sign? Thanks.
@wmtan, @makortel, @abbiendi, @GiacomoSguazzoni, @jhgoh, @VinInn, @appeltel, @rovere, @cerati, @trocino, @dgulhan, @battibass this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 8, 2015

@civanch
Copy link
Contributor

civanch commented May 8, 2015

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented May 8, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @smuzaffar

@cmsbuild
Copy link
Contributor

cmsbuild commented May 8, 2015

@cmsbuild
Copy link
Contributor

cmsbuild commented May 8, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @smuzaffar

@davidlange6
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants