Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use of full5x5 cluster shapes to compute the MVA, read gzipped xml files #9006

Merged

Conversation

emanueledimarco
Copy link
Contributor

Back port to 74X the pull request #8655.
@gpetruc @arizzi @cbernet are also interested in this

@cmsbuild
Copy link
Contributor

cmsbuild commented May 8, 2015

A new Pull Request was created by @emanueledimarco (Emanuele Di Marco) for CMSSW_7_4_X.

backport to 74X branch the capabilities of 75X

It involves the following packages:

EgammaAnalysis/ElectronTools

@cmsbuild, @vadler, @nclopezo, @monttj can you please review it and eventually sign? Thanks.
@Sam-Harper this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 8, 2015

@cmsbuild
Copy link
Contributor

cmsbuild commented May 8, 2015

@arizzi
Copy link
Contributor

arizzi commented May 14, 2015

@monttj can you please comment or approve?

@monttj
Copy link
Contributor

monttj commented May 18, 2015

+1
this is backport to 74X.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

@emanueledimarco - please give this PR a descriptive title for the release notes. Thanks!

@emanueledimarco emanueledimarco changed the title backport to 74X branch the capabilities of 75X Use of full5x5 cluster shapes to compute the MVA, read gzipped xml files May 20, 2015
@emanueledimarco
Copy link
Contributor Author

@davidlange6 done

@davidlange6
Copy link
Contributor

+1
thanks!

cmsbuild added a commit that referenced this pull request May 20, 2015
…tch1

Use of full5x5 cluster shapes to compute the MVA, read gzipped xml files
@cmsbuild cmsbuild merged commit 7d35bb4 into cms-sw:CMSSW_7_4_X May 20, 2015
@emanueledimarco emanueledimarco deleted the egamma_full5x5mva_741patch1 branch June 16, 2015 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants