Fixed bug between edm::Refs and EDAlias #901
Conversation
By decoupling OtherThingAlgorithm from edm::Event allows us to test different ways of getting the data from the Event. Also got rid of the header for OtherThingProducer
… process. A bug was discovered in the interaction between edm::Ref and EDAlias. The bug depends on the exact order between the original and alias branch names and/or branchIDs. The additional tests cause the bug to manifest. The change to the original test to create Refs in step2 is there to catch any possible regressions.
Nulling out the BranchID for a kept EDAlias some times caused edm::Ref’s created in subsequent jobs which refer to the aliased branch to fail. The failure depends on the exact ordering (branch name and/or branch ID) between the original branch and the alias.
|
A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_0_X. Fixed bug between edm::Refs and EDAlias It involves the following packages: DataFormats/Provenance @smuzaffar, @Dr15Jones, @ktf, @nclopezo can you please review it and eventually sign? Thanks. |
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @ktf can you please take care of it? |
Framework buggix -- Fixed bug between edm::Refs and EDAlias
Nulling out the BranchID for a kept EDAlias some times caused edm::Ref’s created in subsequent jobs which refer to the aliased branch to fail. The failure depends on the exact ordering (branch name and/or branch ID) between the original branch and the alias.
This request also has related maintenance changes and additional unit tests.