Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make callWhenNewProductsRegistered public #9019

Merged
merged 1 commit into from May 9, 2015
Merged

Make callWhenNewProductsRegistered public #9019

merged 1 commit into from May 9, 2015

Conversation

wddgit
Copy link
Contributor

@wddgit wddgit commented May 8, 2015

This is needed for the consumes migration of
L1GtUtils. It will make testing the other more
significant parts of that migration easier if
this is integrated quickly. This change is
trivial.

@wddgit
Make callWhenNewProductsRegistered public
a8dc122 
This is needed for the consumes migration of
L1GtUtils. It will make testing the other more
significant parts of that migration easier if
this is integrated quickly. This change is almost
trivial.
@cmsbuild cmsbuild added this to the Next CMSSW_7_5_X milestone May 8, 2015
@cmsbuild
Copy link
Contributor

cmsbuild commented May 8, 2015

A new Pull Request was created by @wddgit (W. David Dagenhart) for CMSSW_7_5_X.

Make callWhenNewProductsRegistered public

It involves the following packages:

FWCore/Framework

@cmsbuild, @Dr15Jones, @nclopezo can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @wmtan this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@Dr15Jones
Copy link
Contributor

please test

@Dr15Jones
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2015

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @smuzaffar

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @smuzaffar

davidlange6 added a commit that referenced this pull request May 9, 2015
@davidlange6
Merge pull request #9019 from wddgit/consumesMigrationL1
e79ea36 
Make callWhenNewProductsRegistered public
@davidlange6 davidlange6 merged commit e79ea36 into cms-sw:CMSSW_7_5_X May 9, 2015
@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2015

+1
Tested at: a8dc122
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9019/4605/summary.html

@wddgit wddgit deleted the consumesMigrationL1 branch July 6, 2015 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-pending core-approved fully-signed orp-pending tests-started
Projects
None yet
Milestone
CMSSW_7_5_X
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@wddgit @cmsbuild @Dr15Jones @davidlange6