Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change args from pass by value to pass by const reference #903

Merged
merged 1 commit into from Sep 25, 2013
Merged

change args from pass by value to pass by const reference #903

merged 1 commit into from Sep 25, 2013

Conversation

gartung
Copy link
Member

@gartung gartung commented Sep 23, 2013

No description provided.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @gartung (Patrick Gartung) for CMSSW_7_0_X.

change args from pass by value to pass by const reference

It involves the following packages:

L1Trigger/GlobalCaloTrigger

@smuzaffar, @nclopezo, @mulhearn can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@ktf you are the release manager for this.

@mulhearn
Copy link
Contributor

Looks like one failure in RunTheMatrix workflow 101. Is this understood?

@Dr15Jones
Copy link
Contributor

Workflow 101 has been failing in the nightly IBs since this weekend. Therefore it was not caused by this pull request.

@mulhearn
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @ktf can you please take care of it?

ktf added a commit that referenced this pull request Sep 25, 2013
Misc cleanups -- Change args from pass by value to pass by const reference in L1Trigger/GlobalCaloTrigger
@ktf ktf merged commit f92593c into cms-sw:CMSSW_7_0_X Sep 25, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants