Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update of muon regional iterative tracking in HI reco #9049

Merged
merged 2 commits into from May 18, 2015

Conversation

echapon
Copy link
Contributor

@echapon echapon commented May 12, 2015

The muon regional iterative (regit) tracking in heavy-ion reconstruction is updated with the following changes:

  • removing the LowPt, Detached and TobTec iterations. These iterations don't change the muon reconstruction efficiency, so removing them saves a bit of time in reconstruction.
  • fixing the algorithm name assigned to tracks found by muon regit, with an existing name. The tracks are assigned the flag "undefAlgorithm", this can be changed if someone has a strong opinion about it.

Documentation of the effect of these changes on the reconstruction performance and resources needed is under finalization and made available very soon. As stated above, the HI muon reconstruction is basically unchanged, only a little bit faster.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @echapon (Emilien Chapon) for CMSSW_7_5_X.

Update of muon regional iterative tracking in HI reco

It involves the following packages:

RecoHI/HiMuonAlgos
RecoHI/HiTracking

@cmsbuild, @cvuosalo, @nclopezo, @slava77 can you please review it and eventually sign? Thanks.
@MiheeJo, @jazzitup, @richard-cms, @appeltel, @yenjie, @kurtejung, @mandrenguyen, @dgulhan, @yetkinyilmaz this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@slava77
Copy link
Contributor

slava77 commented May 12, 2015

@rovere @VinInn are there any issues with setting the tracking algorithm to 0/undefined (and have multiple algorithms running)?

@VinInn
Copy link
Contributor

VinInn commented May 12, 2015

besides debug and validation algo id is used only as last resort in ListMerging
algo id SHALL NOT be used in any track classification

@slava77
Copy link
Contributor

slava77 commented May 12, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@echapon
Copy link
Contributor Author

echapon commented May 16, 2015

Yes, that's a possibility I thought of, which is easy to implement if people like it (it's just about adding algorithm names in TrackBase.h right?). I will implement it if the tracking POG likes the idea.

@cmsbuild
Copy link
Contributor

@slava77
Copy link
Contributor

slava77 commented May 17, 2015

+1

for #9049 10ba8bc

  • changes in the configs are as intended (although additional fine-tuning that requires a new set of track algo enums and labels defined may happen in a following PR).
  • changes affect only HI workflows
  • tested locally in CMSSW_7_5_0_pre4 /local area sign551/
    • default matrix: 140.53 (data) and 140.0 (MC)
    • dimuon skim using 140.53 config and /store/results/hin/StoreResults/HIDiMuon/USER/L2DoubleMu3Skim_v10_38dff9fa051006d6e895e3c1df676d76-v1/40000/001FA005-07D0-E411-A6C2-0026B95A4D42.root
  • most visible changes are in the technical performance in the CPU: about 0.8% reduction from removal of lowPt triplet, detached tripled, and tob-tec mu regional iterations
  • event content changes very little:
    • 0.2% to 0.4% less hiGeneralTracks (higher reduction in the dimu skim)
    • 0.9% less reco muons in plain 140.53 and 1.2% less in the dimu skim
  • physics performance changes are pretty minor based on the monitored quantities (in particular, checking the MC sample validation plots: efficiencies and fake rates are practically the same on the "global" scale)

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @smuzaffar

@davidlange6
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants