New dataformat/producer for Heavy Ion AOD photons

[harmonicoscillator]

Hello,

Heavy Ions is (finally) switching to an AOD-based workflow for 2015 data. AOD will not contain several collections (ecal rechits, hcal rechits) that we were previously using at analysis level to compute photon isolation variables. This information is absolutely essential for all Heavy Ion photon analyses, past and present.

In this branch I've proposed a straw-man solution, which is to make a new dataformat which inherits from reco::photon and includes new datamembers for Heavy Ion use. The isolation and some spike information is saved in the new dataformat and kept in AOD.

I realize that adding new dataformats is not trivial, so I'm expecting this PR to get shot down, but any advice on a better method would be much appreciated.

@lgray @yetkinyilmaz

[cmsbuild]

A new Pull Request was created by @richard-cms (R. Alex Barbieri) for CMSSW_7_5_X.

New dataformat/producer for Heavy Ion AOD photons

It involves the following packages:

DataFormats/EgammaCandidates
RecoHI/HiEgammaAlgos

@cmsbuild, @cvuosalo, @nclopezo, @slava77 can you please review it and eventually sign? Thanks.
@Sam-Harper, @jazzitup, @lgray, @appeltel, @yenjie, @kurtejung, @mandrenguyen, @dgulhan, @yetkinyilmaz this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[slava77]

@cmsbuild please test

@richard-cms
There will be a lot of comments to the code.
Before going through a detailed review, please clarify how "final" is this code from functionality perspective.
If it's something temporary that will be changed a lot before it becomes useable, it's unclear if it has to be in the release now.
Currently it looks like you are using PR on github as a medium to post and share the code.

Please clarify which meetings this was presented in, a link would be nice.

[cmsbuild]

The tests are being triggered in jenkins.

[cmsbuild]

+1
Tested at: 1ae5a69
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9057/4635/summary.html

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @smuzaffar

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9057/4883/summary.html

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @smuzaffar

[davidlange6]

+1