bsunanda:Run2 alca14 Get rid of unused variables and avoid explicit names

[bsunanda]

Remove some of the unused variables. Avoid using explicit names in the name of the products. Correct the selection function to avoid assumptions in warning. Change some getByLabel with getByToken. Use LogDebug in the DQM code.

[cmsbuild]

A new Pull Request was created by @bsunanda for CMSSW_7_5_X.

bsunanda:Run2 alca13 Get rid of unused variables and avoid explicit names

It involves the following packages:

Calibration/HcalAlCaRecoProducers
Calibration/IsolatedParticles
DQMOffline/CalibCalo

@diguida, @danduggan, @cerminar, @cmsbuild, @nclopezo, @deguio, @mmusich can you please review it and eventually sign? Thanks.
@rociovilar this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[diguida]

@cmsbuild please test

[mmusich]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.

[diguida]

@bsunanda IIUC the tests you perform are:

1. Test if the Photon collection is empty: return false if so;
2. Check the requirement for minimum pT: at least one PFJet should have pt larger than the threshold, otherwise return false;
3. Check the requirement for minimum pT: at least one Photon should have pt larger than the threshold. If so, return true, otherwise false.

[bsunanda]

Yes - we need events with at least one high pt jet and one high pt photon. The assumption of ordering was found to be incorrect - so the code is optimized this way.

---

From: Salvatore Di Guida [notifications@github.com]
Sent: 13 May 2015 10:17
To: cms-sw/cmssw
Cc: Sunanda Banerjee
Subject: Re: [cmssw] bsunanda:Run2 alca13 Get rid of unused variables and avoid explicit names (#9062)

In Calibration/HcalAlCaRecoProducers/src/AlCaGammaJetProducer.cchttps://github.com//pull/9062#discussion_r30210248:

• // Check the requirement for minimum pT
• if (ph.size() == 0) return false;
• bool ok(false);
• for (reco::PFJetCollection::const_iterator itr=jt.begin();

•   itr!=jt.end(); ++itr) {
  

• if (itr->pt() >= minPtJet_) {

•  ok = true;
  

•  break;
  

• }
• }
• if (!ok) return ok;
• for (reco::PhotonCollection::const_iterator itr=ph.begin();

•   itr!=ph.end(); ++itr) {
  

• if (itr->pt() >= minPtPhoton_) return ok;
• }
• return false;
  }

@bsunandahttps://github.com/bsunanda IIUC the tests you perform are:

1. Test if the Photon collection is empty: return false if so;
2. Check the requirement for minimum pT: at least one PFJet should have pt larger than the threshold, otherwise return false;
3. Check the requirement for minimum pT: at least one Photon should have pt larger than the threshold. If so, return true, otherwise false.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/9062/files#r30210248.

[cmsbuild]

+1
Tested at: eac62e1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9062/4632/summary.html

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @smuzaffar

[davidlange6]

+1