Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for Tracker Parameters from DB PR #9074

Merged

Conversation

ianna
Copy link
Contributor

@ianna ianna commented May 13, 2015

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ianna (Ianna Osborne) for CMSSW_7_5_X.

Fixes for Tracker Parameters from DB PR

It involves the following packages:

HLTrigger/Configuration
Validation/RecoHI

@perrotta, @cmsbuild, @nclopezo, @danduggan, @Martin-Grunewald, @deguio, @fwyzard can you please review it and eventually sign? Thanks.
@kkrajczar, @geoff-smith, @Martin-Grunewald, @RylanC24, @jalimena, @richard-cms this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@ianna
Copy link
Contributor Author

ianna commented May 13, 2015

Note, it should be taken on top of #7966

@Martin-Grunewald
Copy link
Contributor

+1
but only in conjunction with #7966

@cmsbuild
Copy link
Contributor

-1
Tested at: d3d3dbd
I found an error when building:

>> Compiling edm plugin /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_5_X_2015-05-13-2300/src/DQMServices/ClientConfig/plugins/DQMGenericClient.cc 
>> Compiling edm plugin /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_5_X_2015-05-13-2300/src/DQMServices/ClientConfig/plugins/SealModule.cc 
>> Compiling edm plugin /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_5_X_2015-05-13-2300/src/Validation/RecoHI/plugins/HiBasicGenTest.cc 
>> Compiling edm plugin /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_5_X_2015-05-13-2300/src/Validation/RecoHI/plugins/HitPixelLayersTPSelector.cc 
In file included from /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_5_X_2015-05-13-2300/src/Validation/RecoHI/plugins/HitPixelLayersTPSelector.cc:3:0:
/build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_5_X_2015-05-13-2300/src/Validation/RecoHI/plugins/HitPixelLayersTPSelector.h:10:59: fatal error: Geometry/Records/interface/TrackerTopologyRcd.h: No such file or directory
 #include "Geometry/Records/interface/TrackerTopologyRcd.h"
                                                           ^
compilation terminated.
In file included from /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_5_X_2015-05-13-2300/src/Validation/RecoHI/plugins/HitPixelLayersTPSelector.cc:3:0:
/build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_5_X_2015-05-13-2300/src/Validation/RecoHI/plugins/HitPixelLayersTPSelector.h:10:59: fatal error: Geometry/Records/interface/TrackerTopologyRcd.h: No such file or directory


you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9074/4665/summary.html

@ianna
Copy link
Contributor Author

ianna commented May 14, 2015

@cmsbuild - this PR should be taken in conjunction with #7966.

davidlange6 added a commit that referenced this pull request May 14, 2015
@davidlange6 davidlange6 merged commit 76be32f into cms-sw:CMSSW_7_5_X May 14, 2015
@ianna ianna deleted the fixes-for-tracker-parameters-fromDB branch October 26, 2015 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants