Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

74x: Additional features needed for P5 visualization #9080

Merged
merged 25 commits into from Jun 2, 2015

Conversation

alja
Copy link
Contributor

@alja alja commented May 13, 2015

No description provided.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @alja (Alja Mrak-Tadel) for CMSSW_7_4_X.

74x: Additional features needed for P5 visualiation

It involves the following packages:

Fireworks/Calo
Fireworks/Core
Fireworks/FWInterface

@cmsbuild, @alja, @Dr15Jones, @nclopezo can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@alja
Copy link
Contributor Author

alja commented May 13, 2015

Scaling of rechits per collection.

Screenshot: scaled EB rechits for factor of 5
screen shot 2015-05-13 at 1 19 34 pm

@alja
Copy link
Contributor Author

alja commented May 13, 2015

Add option to draw ECal halo in 3D Tower view

towe-halo

@alja
Copy link
Contributor Author

alja commented May 13, 2015

Stop autoplay events on 'Space' key

By the default Ctrl+Space switches mode of play space.
In live event display mode Space key can only stop playing of events. The Space key would else grab all Space events in collection filter editor and event filter editor.

@alja alja changed the title 74x: Additional features needed for P5 visualiation 74x: Additional features needed for P5 visualization May 13, 2015
@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@davidlange6
Copy link
Contributor

Some combination of this package and debug symbols is making our patch release build die. For tonight, I'll revert this so the rest can go forward and then we'll merge this in tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants