Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

moved ParticleTowerProducer_cff.py to cfi for inclusion in confdb an… #9089

Merged
merged 2 commits into from May 16, 2015

Conversation

cfmcginn
Copy link
Contributor

Moved RecoHI/HiJetAlgos/python/ParticleTowerProducer_cff.py to cfi for inclusion in confdb and hlt dev.
See HLT Dev. Hypernews for relevant conversation (a search of my username I think is enough to find).

@kkrajczar

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @cfmcginn (Chris) for CMSSW_7_5_X.

moved ParticleTowerProducer_cff.py to cfi for inclusion in confdb an

It involves the following packages:

RecoHI/HiJetAlgos

@cmsbuild, @cvuosalo, @nclopezo, @slava77 can you please review it and eventually sign? Thanks.
@yslai, @jazzitup, @richard-cms, @appeltel, @yenjie, @kurtejung, @mandrenguyen, @dgulhan, @yetkinyilmaz this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@slava77
Copy link
Contributor

slava77 commented May 14, 2015

Please remove the cff file or change it to include the cfi file.

@cmsbuild
Copy link
Contributor

Pull request #9089 was updated. @cmsbuild, @cvuosalo, @nclopezo, @slava77 can you please check and sign again.

@slava77
Copy link
Contributor

slava77 commented May 14, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

-1
Tested at: 5f4ed12
you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9089/4670/summary.html

@slava77
Copy link
Contributor

slava77 commented May 15, 2015

+1

for #9089 5f4ed12
purely technical change
jenkins tests completed and comparisons with the baseline show no difference

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @smuzaffar

@davidlange6
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants