Thread safe changes for DTTrig class #910
Conversation
|
A new Pull Request was created by @vkuznet (Valentin Kuznetsov) for CMSSW_7_0_X. Thread safe changes for DTTrig class It involves the following packages: CondFormats/DTObjects @smuzaffar, @apfeiffer1, @nclopezo, @demattia, @rcastello, @ggovi can you please review it and eventually sign? Thanks. |
|
@Dr15Jones please review |
| pBuf = const_cast<DTBufferTree<int,int>**>( &dBuf ); | ||
| *pBuf = new DTBufferTree<int,int>; | ||
| // | ||
| #if !defined(__CINT__) && !defined(__MAKECINT__) && !defined(__REFLEX__) |
There was a problem hiding this comment.
Why the #if for ROOT here? ROOT's parser (Cint) should never have to parse this file. If it is then we should look into it.
There was a problem hiding this comment.
Indeed, I removed these statements and code compiles just fine.
On Sep 24, 2013, at ,Sep 24, 12:26 PM, Chris Jones wrote:
In CondFormats/DTObjects/src/DTTtrig.cc:
@@ -396,9 +395,12 @@ void DTTtrig::cacheMap() const {
// std::string mName = mapName();
// DTBufferTree<int,int>* dBuf =
// DTDataBuffer<int,int>::openBuffer( mName );
- DTBufferTree<int,int>** pBuf;
- pBuf = const_cast<DTBufferTree<int,int>**>( &dBuf );
- *pBuf = new DTBufferTree<int,int>;
+//
+#if !defined(CINT) && !defined(MAKECINT) && !defined(REFLEX)
Why the #if for ROOT here? ROOT's parser (Cint) should never have to parse this file. If it is then we should look into it.—
Reply to this email directly or view it on GitHub.
|
Pull request #910 was updated. @smuzaffar, @apfeiffer1, @nclopezo, @demattia, @rcastello, @ggovi can you please check and sign again. |
|
|
||
| //atomically try to swap this to become dBuf | ||
| DTBufferTree<int,int>* expect = nullptr; | ||
| bool exchanged = dBuf.compare_exchange_strong(expect, pBuf); |
There was a problem hiding this comment.
should use std::memory_order_acq_rel
|
All |
|
And you complained about my comma operator?!?!?!?! ;-) |
|
Pull request #910 was updated. @smuzaffar, @apfeiffer1, @nclopezo, @demattia, @rcastello, @ggovi can you please check and sign again. |
|
Looks good to me |
|
+1 |
1 similar comment
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @ktf can you please take care of it? |
Thread safety fixes -- Thread safe changes for DTTrig class
No description provided.