Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bsunanda:Run2-gem07 Update the latest GEM geometry for GE11 #9113

Merged
merged 3 commits into from May 29, 2015

Conversation

bsunanda
Copy link
Contributor

Update GE11 geometry with the latest design

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @bsunanda for CMSSW_7_5_X.

bsunanda:Run2-gem07 Update the latest GEM geometry for GE11

It involves the following packages:

Geometry/MuonCommonData

@civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @nclopezo can you please review it and eventually sign? Thanks.
@ghellwig this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

@ianna
Copy link
Contributor

ianna commented May 26, 2015

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @smuzaffar

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @smuzaffar

@cmsbuild
Copy link
Contributor

@davidlange6
Copy link
Contributor

@bsunanda - do we need so many versions of the gem11 file? Can we just keep one?

@bsunanda
Copy link
Contributor Author

I understand from GEM guys still want several versions of GE11. This is something which I cannot decide. My understanding is that after some time (may be in several months) only one version (or a very few versions) will be kept. I am working on GE21 now and soon there will be 2 versions of that as well.


From: David Lange [notifications@github.com]
Sent: 27 May 2015 20:06
To: cms-sw/cmssw
Cc: Sunanda Banerjee
Subject: Re: [cmssw] bsunanda:Run2-gem07 Update the latest GEM geometry for GE11 (#9113)

@bsunandahttps://github.com/bsunanda - do we need so many versions of the gem11 file? Can we just keep one?


Reply to this email directly or view it on GitHubhttps://github.com//pull/9113#issuecomment-106016195.

@bsunanda
Copy link
Contributor Author

I checked with GEM DPG and there is a request to keep mutiple versions of GE11 geometry for a while. They still analyze data with a few definitions of GE11.


From: Sunanda Banerjee
Sent: 27 May 2015 20:29
To: cms-sw/cmssw; cms-sw/cmssw
Subject: RE: [cmssw] bsunanda:Run2-gem07 Update the latest GEM geometry for GE11 (#9113)

I understand from GEM guys still want several versions of GE11. This is something which I cannot decide. My understanding is that after some time (may be in several months) only one version (or a very few versions) will be kept. I am working on GE21 now and soon there will be 2 versions of that as well.


From: David Lange [notifications@github.com]
Sent: 27 May 2015 20:06
To: cms-sw/cmssw
Cc: Sunanda Banerjee
Subject: Re: [cmssw] bsunanda:Run2-gem07 Update the latest GEM geometry for GE11 (#9113)

@bsunandahttps://github.com/bsunanda - do we need so many versions of the gem11 file? Can we just keep one?


Reply to this email directly or view it on GitHubhttps://github.com//pull/9113#issuecomment-106016195.

@davidlange6
Copy link
Contributor

@bsunanda - analyzing presumably happens in 62XSLHC? Instead, its a question of producing new data. I don't want a bunch of already obsolete geometries to be moved forward to 75x.

@bsunanda
Copy link
Contributor Author

David, I have not added any new xml file there. They were already there. I just corrected some of them which are to be used.


From: David Lange [notifications@github.com]
Sent: 28 May 2015 17:46
To: cms-sw/cmssw
Cc: Sunanda Banerjee
Subject: Re: [cmssw] bsunanda:Run2-gem07 Update the latest GEM geometry for GE11 (#9113)

@bsunandahttps://github.com/bsunanda - analyzing presumably happens in 62XSLHC? Instead, its a question of producing new data. I don't want a bunch of already obsolete geometries to be moved forward to 75x.


Reply to this email directly or view it on GitHubhttps://github.com//pull/9113#issuecomment-106428785.

@davidlange6
Copy link
Contributor

+1
right - ok - lets plan on getting these soon to be obsolete geometries cleaned when we can

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants