Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use shrink_to_fit on TrackProducer collections #9147

Merged
merged 3 commits into from May 20, 2015

Conversation

mark-grimes
Copy link

Uses shrink_to_fit to reduce the memory used by the produced collections in TrackProducer, basically backported from 74X. This also adds shrink_to_fit to the edm::OwnVector interface, also backported from 74X.
Note that since this includes a change to the edm::OwnVector header a checkdeps will pull in 417 packages.

Even though each individual TrackProducer doesn't have comparatively large collections, because there are so many of them if you sum up by producer type it's actually one of the largest. This plot is 200 pileup before applying this pull request (but with some of the other PRs in the queue):
productsizebyclass

I've been doing a few tests and it doesn't seem to make a huge amount of difference. I didn't do the checkdeps, but I don't see why that would have made a difference. Anyway, the shrink_to_fit is only going to improve things - peak memory use is not a problem for TrackProducer.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mark-grimes (Mark Grimes) for CMSSW_6_2_X_SLHC.

Use shrink_to_fit on TrackProducer collections

It involves the following packages:

DataFormats/Common
RecoTracker/TrackProducer

@nclopezo, @cvuosalo, @cmsbuild, @Dr15Jones, @slava77 can you please review it and eventually sign? Thanks.
@ghellwig, @wmtan, @makortel, @GiacomoSguazzoni, @wddgit, @VinInn, @appeltel, @mschrode, @rovere, @gpetruc, @cerati, @dgulhan, @venturia this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@fratnikov, @mark-grimes you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@mark-grimes
Copy link
Author

merge

cmsbuild added a commit that referenced this pull request May 20, 2015
Use shrink_to_fit on TrackProducer collections
@cmsbuild cmsbuild merged commit a87d91d into cms-sw:CMSSW_6_2_X_SLHC May 20, 2015
@cmsbuild
Copy link
Contributor

-1

Tested at: 1094f04
I found errors in the following unit tests:

---> test runtestPhysicsToolsPatAlgos had ERRORS
---> test runtestTqafTopEventSelection had ERRORS
---> test runtestTqafTopKinFitter had ERRORS
---> test runtestTqafTopSkimming had ERRORS
---> test runtestTqafTopEventProducers had ERRORS
---> test runtestTqafExamples had ERRORS
---> test runtestTqafTopTools had ERRORS
---> test runtestTqafTopHitFit had ERRORS
---> test runtestTqafTopJetCombination had ERRORS
---> test runtestUtilAlgos had ERRORS

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9147/4850/summary.html

@mark-grimes mark-grimes deleted the recoTracksShrinkToFit branch May 21, 2015 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants