Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

point seeded tracking regions #9149

Conversation

mtosi
Copy link
Contributor

@mtosi mtosi commented May 19, 2015

this is the first (and probably really rude) version a new tracking region creator
starting from a point in eta-phi plane (the r component is set to 1)
@VinInn @rovere

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mtosi (mia tosi) for CMSSW_7_5_X.

point seeded tracking regions

It involves the following packages:

RecoTauTag/HLTProducers

@Martin-Grunewald, @perrotta, @cmsbuild, @nclopezo, @fwyzard can you please review it and eventually sign? Thanks.
@jpavel this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@Martin-Grunewald
Copy link
Contributor

Why do we need existAs in new code?
There is no fillDescriptions method.
Is the base class already a thread-safe EDProducer?

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Pull request #9149 was updated. @Martin-Grunewald, @cvuosalo, @perrotta, @fwyzard, @slava77 can you please check and sign again.

@VinInn
Copy link
Contributor

VinInn commented May 19, 2015

Thanks, actually we are interested to use it offline as well

@@ -32,6 +33,7 @@
DEFINE_EDM_PLUGIN(TrackingRegionProducerFactory, TauRegionalPixelSeedGenerator, "TauRegionalPixelSeedGenerator");
DEFINE_EDM_PLUGIN(TrackingRegionProducerFactory, TrackingRegionsFromBeamSpotAndL2Tau, "TrackingRegionsFromBeamSpotAndL2Tau");
DEFINE_EDM_PLUGIN(TrackingRegionProducerFactory, CandidateSeededTrackingRegionsProducer, "CandidateSeededTrackingRegionsProducer");
//DEFINE_EDM_PLUGIN(TrackingRegionProducerFactory, PointSeededTrackingRegionsProducer, "PointSeededTrackingRegionsProducer");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please just restore the file as it was before this PR (adding commented lines is useless and requires HLT signature):
RecoTauTag/HLTProducers/src/SealModule.cc

@cmsbuild
Copy link
Contributor

@cvuosalo
Copy link
Contributor

+1

For #9149 0cb9bf7

This PR adds a new tracking region creator. The new code is not called by standard sequences yet, so it should not change monitored quantities.

The new code is satisfactory, and Jenkins tests against baseline CMSSW_7_5_X_2015-05-18-1100 show no significant differences, as expected.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request May 22, 2015
…TrackingRegions

point seeded tracking regions
@cmsbuild cmsbuild merged commit 6b3b490 into cms-sw:CMSSW_7_5_X May 22, 2015
mtosi added a commit to mtosi/cmssw that referenced this pull request Jul 15, 2015
slava77 pushed a commit to slava77/cmssw that referenced this pull request Jul 19, 2015
cmsbuild added a commit that referenced this pull request Aug 1, 2015
…kingRegion

point seeded tracking regions (backport PR #9149)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants