New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
point seeded tracking regions #9149
point seeded tracking regions #9149
Conversation
A new Pull Request was created by @mtosi (mia tosi) for CMSSW_7_5_X. point seeded tracking regions It involves the following packages: RecoTauTag/HLTProducers @Martin-Grunewald, @perrotta, @cmsbuild, @nclopezo, @fwyzard can you please review it and eventually sign? Thanks. |
Why do we need existAs in new code? |
…s to RecoTracker/TkTrackingRegions
Thanks, actually we are interested to use it offline as well |
@@ -32,6 +33,7 @@ | |||
DEFINE_EDM_PLUGIN(TrackingRegionProducerFactory, TauRegionalPixelSeedGenerator, "TauRegionalPixelSeedGenerator"); | |||
DEFINE_EDM_PLUGIN(TrackingRegionProducerFactory, TrackingRegionsFromBeamSpotAndL2Tau, "TrackingRegionsFromBeamSpotAndL2Tau"); | |||
DEFINE_EDM_PLUGIN(TrackingRegionProducerFactory, CandidateSeededTrackingRegionsProducer, "CandidateSeededTrackingRegionsProducer"); | |||
//DEFINE_EDM_PLUGIN(TrackingRegionProducerFactory, PointSeededTrackingRegionsProducer, "PointSeededTrackingRegionsProducer"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please just restore the file as it was before this PR (adding commented lines is useless and requires HLT signature):
RecoTauTag/HLTProducers/src/SealModule.cc
+1 This PR adds a new tracking region creator. The new code is not called by standard sequences yet, so it should not change monitored quantities. The new code is satisfactory, and Jenkins tests against baseline CMSSW_7_5_X_2015-05-18-1100 show no significant differences, as expected. |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @smuzaffar |
+1 |
…TrackingRegions point seeded tracking regions
…kingRegion point seeded tracking regions (backport PR #9149)
this is the first (and probably really rude) version a new tracking region creator
starting from a point in eta-phi plane (the r component is set to 1)
@VinInn @rovere