Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bsunanda:Run2-hcx11 Add new products required for HGCal #9166

Merged
merged 2 commits into from
May 28, 2015

Conversation

bsunanda
Copy link
Contributor

Extend DetId to forward detectors in view of HGCal and related detectors. Also add definitions for Digi and RecHit

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @bsunanda for CMSSW_7_5_X.

bsunanda:Run2-hcx11 Add new products required for HGCal

It involves the following packages:

DataFormats/DetId
DataFormats/ForwardDetId
DataFormats/HGCDigi
DataFormats/HGCRecHit

The following packages do not have a category, yet:

DataFormats/ForwardDetId
DataFormats/HGCDigi
DataFormats/HGCRecHit

@cmsbuild, @civanch, @nclopezo, @mdhildreth can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

@civanch
Copy link
Contributor

civanch commented May 20, 2015

@bsunanda , I may be miss something, where boost is used in these codes?

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@smuzaffar
Copy link
Contributor

there are few unittest which are failing due to this in the latest 75X IB. Looks like duplicate
DataFormats/HGCDigi/src/classes_def.xml:
DataFormats/ForwardDetId/src/classes_def.xml:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants