Remove Obsolete Code

[ianna]

• Clean up dependencies
• Update tutorial
• Remove commented out code
• Remove obsolete/unused code

[ianna]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @smuzaffar

[cmsbuild]

-1
Tested at: 50c9e8e
I found an error when building:

Leaving library rule at MagneticField/VolumeBasedEngine
Entering library rule at src/FastSimulation/CaloGeometryTools/test
>> Building shared library tmp/slc6_amd64_gcc491/src/Geometry/EcalAlgo/src/GeometryEcalAlgo/libGeometryEcalAlgo.so
/afs/cern.ch/cms/sw/ReleaseCandidates/volB/slc6_amd64_gcc491/external/gcc/4.9.1-cms/bin/../lib/gcc/x86_64-redhat-linux-gnu/4.9.1/../../../../x86_64-redhat-linux-gnu/bin/ld: cannot find -lCondCoreDBOutputService
/afs/cern.ch/cms/sw/ReleaseCandidates/volB/slc6_amd64_gcc491/external/gcc/4.9.1-cms/bin/../lib/gcc/x86_64-redhat-linux-gnu/4.9.1/../../../../x86_64-redhat-linux-gnu/bin/ld: cannot find -lCondCoreCondDB
collect2: error: ld returned 1 exit status
gmake: **\* [tmp/slc6_amd64_gcc491/src/Geometry/EcalAlgo/src/GeometryEcalAlgo/libGeometryEcalAlgo.so] Error 1
Leaving library rule at Geometry/EcalAlgo
>> Building shared library tmp/slc6_amd64_gcc491/src/RecoMuon/DetLayers/src/RecoMuonDetLayers/libRecoMuonDetLayers.so
Entering library rule at RecoTracker/TransientTrackingRecHit
>> Compiling  /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_5_X_2015-05-27-2300/src/RecoLocalTracker/SiStripRecHitConverter/src/CrosstalkInversion.cc 


you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9307/5090/summary.html

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes (but tests are reportedly failing). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @smuzaffar

[ianna]

@cmsbuild - it looks like a problem with IB - I do not see CondCore/CondDB package built or even mentioned.

[smuzaffar]

yes, there was problem with last IB due to coral. Today's 11h00 IB
should have the fix.

On 05/28/2015 02:41 PM, Ianna Osborne wrote:

@cmsbuild https://github.com/cmsbuild - it looks like a problem with
IB - I do not see CondCore/CondDB package built or even mentioned.

—
Reply to this email directly or view it on GitHub
#9307 (comment).

[ianna]

@smuzaffar - thanks! I hope, the tests will be re-triggered.

[ianna]

+1

[cmsbuild]

-1

Tested at: 7b8cb39
I found errors in the following unit tests:

---> test dumpDDExpandedView had ERRORS
---> test testmat had ERRORS
---> test testDDCompactView had ERRORS
---> test dumpDDCompactView had ERRORS

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9307/5110/summary.html

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes (but tests are reportedly failing). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @smuzaffar

[ianna]

@cmsbuild - the unit tests fail due to another PR problem:

class  HGCEEDetId found in libDataFormatsHGCDigi.so  is already in libDataFormatsForwardDetId.so 

[smuzaffar]

yes looks like #9166 has caused this and these unit tests are failing in the IB already.
@davidlange6 , this pull request can be included we need to fix the changes/duplicates introduced in #9166

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9307/5110/summary.html

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes (but tests are reportedly failing). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @smuzaffar