Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport secondary input source improvements from 7_5_X #9181

Merged
merged 1 commit into from May 22, 2015

Conversation

wmtan
Copy link
Contributor

@wmtan wmtan commented May 20, 2015

Improvements to the secondary input source, back ported from 7_5_X, as requested at Core Software meeting:

  1. skipEvents parameter now supported in sequential mode (AKA deterministic mode)
  2. sequential mode now loops back to first file after the last file
  3. First file opened is randomized.
    Items 1) and 2) are needed to support the avoidance of duplication in the use of premixed pileup.
    This is a back port of PR's Secondary input source improvements/fixes #9091, Remove cerr left in inadvertently #9155, and Skip all entries (per file) at once, not one at a time. #9163 combined, not including the unit test enhancement, which is not being back ported.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @wmtan for CMSSW_7_4_X.

Backport secondary input source improvements from 7_5_X

It involves the following packages:

IOPool/Input

@cmsbuild, @Dr15Jones, @nclopezo can you please review it and eventually sign? Thanks.
@wddgit this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@Dr15Jones
Copy link
Contributor

please test

@Dr15Jones
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request May 22, 2015
Backport secondary input source improvements from 7_5_X
@cmsbuild cmsbuild merged commit 31ab171 into cms-sw:CMSSW_7_4_X May 22, 2015
@wmtan wmtan deleted the SecondarySourceImprovements branch May 27, 2015 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants