Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests of cache types for EDProducer, EDAnalyzer and EDFilter #920

Merged
merged 4 commits into from Sep 28, 2013
Merged

Tests of cache types for EDProducer, EDAnalyzer and EDFilter #920

merged 4 commits into from Sep 28, 2013

Conversation

gartung
Copy link
Member

@gartung gartung commented Sep 25, 2013

Tests of cache types for EDProducer, EDAnalyzer and EDFilter in the edm::global,edm::stream and edm::one namespaces

…dm::global,edm::stream and edm::one namespaces
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @gartung (Patrick Gartung) for CMSSW_7_0_X.

Tests of cache types for EDProducer, EDAnalyzer and EDFilter

It involves the following packages:

FWCore/Framework

@smuzaffar, @Dr15Jones, @ktf, @nclopezo can you please review it and eventually sign? Thanks.
@wmtan this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@ktf you are the release manager for this.

};


class StreamIntAnalyzer: public edm::global::EDAnalyzer<edm::StreamCache<Cache>> {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use a edm::StreamCache here since each stream gets its own independent cache.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of m_count?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

m_count still has a use since it is seen by all transitions.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Git ate your . Now I understand your comment.

@gartung gartung closed this Sep 27, 2013
@gartung gartung reopened this Sep 27, 2013
@cmsbuild
Copy link
Contributor

Pull request #920 was updated. @smuzaffar, @Dr15Jones, @ktf, @nclopezo can you please check and sign again.

…yBlock, etc

Note edm::stream::RunCache<void> and edm::stream::LuminosityBlockCache<void>
do not work in the BeginRunProduce, BeginLuminosityBlockProduce context
@cmsbuild
Copy link
Contributor

Pull request #920 was updated. @smuzaffar, @Dr15Jones, @ktf, @nclopezo can you please check and sign again.

@Dr15Jones
Copy link
Contributor

+1
As long as the Jenkin's test pass

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @ktf can you please take care of it?

ktf added a commit that referenced this pull request Sep 28, 2013
Multithreaded framework -- Tests of cache types for EDProducer, EDAnalyzer and EDFilter
@ktf ktf merged commit d51b9b1 into cms-sw:CMSSW_7_0_X Sep 28, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants