New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests of cache types for EDProducer, EDAnalyzer and EDFilter #920
Conversation
…dm::global,edm::stream and edm::one namespaces
A new Pull Request was created by @gartung (Patrick Gartung) for CMSSW_7_0_X. Tests of cache types for EDProducer, EDAnalyzer and EDFilter It involves the following packages: FWCore/Framework @smuzaffar, @Dr15Jones, @ktf, @nclopezo can you please review it and eventually sign? Thanks. |
}; | ||
|
||
|
||
class StreamIntAnalyzer: public edm::global::EDAnalyzer<edm::StreamCache<Cache>> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can use a edm::StreamCache here since each stream gets its own independent cache.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of m_count?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
m_count still has a use since it is seen by all transitions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Git ate your . Now I understand your comment.
Pull request #920 was updated. @smuzaffar, @Dr15Jones, @ktf, @nclopezo can you please check and sign again. |
…yBlock, etc Note edm::stream::RunCache<void> and edm::stream::LuminosityBlockCache<void> do not work in the BeginRunProduce, BeginLuminosityBlockProduce context
Pull request #920 was updated. @smuzaffar, @Dr15Jones, @ktf, @nclopezo can you please check and sign again. |
+1 |
This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @ktf can you please take care of it? |
Multithreaded framework -- Tests of cache types for EDProducer, EDAnalyzer and EDFilter
Tests of cache types for EDProducer, EDAnalyzer and EDFilter in the edm::global,edm::stream and edm::one namespaces