Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make 10MB the default stack size for additional threads #9205

Merged

Conversation

Dr15Jones
Copy link
Contributor

Many of our ROOT files require very deep stacks in order to be able to read back certain branches. When read on a non-main thread the default stack size used by TBB is often too small. 10MB appears to be sufficiently large.

Many of our ROOT files require very deep stacks in order to be able to read back certain branches. When read on a non-main thread the default stack size used by TBB is often too small. 10MB appears to be sufficiently large.
@Dr15Jones
Copy link
Contributor Author

Backport requested from hypernews thread https://hypernews.cern.ch/HyperNews/CMS/get/edmFramework/3507.html

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_4_X.

Make 10MB the default stack size for additional threads

It involves the following packages:

FWCore/Framework

@cmsbuild, @Dr15Jones, @nclopezo can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @wddgit, @wmtan this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@Dr15Jones
Copy link
Contributor Author

please test

@Dr15Jones
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

davidlange6 added a commit that referenced this pull request May 21, 2015
…s_7_4

Make 10MB the default stack size for additional threads
@davidlange6 davidlange6 merged commit f08559b into cms-sw:CMSSW_7_4_X May 21, 2015
@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@Dr15Jones Dr15Jones deleted the make10MBDefaultStackForThreads_7_4 branch August 14, 2015 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants