L1t updates 75x #9216
L1t updates 75x #9216
Conversation
…e/cmssw into mydev-branch
…e/cmssw into mydev-branch
…e/cmssw into mydevel-branch
…e/cmssw into mydevel-branch
|
I believe this PR broke HLT tests - see here: |
|
@mulhearn @jimbrooke |
|
@mulhearn @jimbrooke @puigh @davidlange6 |
| @@ -94,7 +95,16 @@ def customiseSimL1EmulatorForPostLS1_HI(process): | |||
| # load the Stage 1 configuration | |||
| process = customiseSimL1EmulatorForStage1(process) | |||
| # set the Stage 1 heavy ions-specific parameters | |||
| process.simCaloStage1Digis.FirmwareVersion = cms.uint32(1) | |||
| # all of these should eventually end up in a GT | |||
| process.RCTConfigProducers.eicIsolationThreshold = cms.uint32(7) | |||
There was a problem hiding this comment.
@mulhearn Two of the HLT breaks come from my commits - they can be fixed by adding "hasattr" guards on process.RCTConfigProducers here.
Fix 2/3 of HLT test breakages caused by PR #9216
|
The remaining error is due to the new L1TCaloConfig DB table, which is intended to remove our dependence on config files. In principle this could be fixed by a new GT, but this isn't ready yet. Our intention was to default to local config but it seems something went wrong. Let me remind myself how to default this table properly... |
|
Until we have the new GT, the HLT workflows needs to call: process.load('L1Trigger.L1TCalorimeter.caloConfigStage1PP_cfi') |
|
This didn't break the workflows in runTheMatrix.py because it is being setup by "customiseSimL1EmulatorForStage1". We clearly need to add some additional tests for our unit testing... |
|
Actually looks like this is just a mistake in the 50ns customizations... it is not calling the setup common to 25/50 ns. |
|
Seems to work... |
Updates for L1 Trigger needed for 75X. Updates from HI. Calorimeter trigger updates. Unpacker updates to improve data/hardware agreement. Updates for Stage2 calorimeter.