Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename jettoolbox_cfg.py to testJettools_cfg.py to avoid confusion #9291

Merged
merged 2 commits into from May 28, 2015

Conversation

alefisico
Copy link
Contributor

New version is a stand-alone package here: https://github.com/cms-jet/JetToolbox

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @alefisico (Alejandro Gomez Espinosa) for CMSSW_7_5_X.

removing jettoolbox from CMSSW

It involves the following packages:

RecoJets/JetProducers

@cmsbuild, @cvuosalo, @nclopezo, @slava77 can you please review it and eventually sign? Thanks.
@rappoccio, @jdolen, @ahinzmann, @TaiSakuma, @yslai, @nhanvtran, @schoef, @mariadalfonso this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@slava77
Copy link
Contributor

slava77 commented May 27, 2015

this was a good test file to check jet-related algorithms not included in standard workflows.
What can we use now during integration?

@ahinzmann
Copy link
Contributor

The motivation to remove it from the release it is that it is outdated and causes confusion, while a better version is in the works.
It is indeed useful for tests. How about just renaming it to testJetTools_cfg.py

@slava77
Copy link
Contributor

slava77 commented May 27, 2015

What prevents you from having this file more up to date with the release?
Unless the file goes out of date on a 1-week time scale all the time, the release schedule is typically frequent enough to be up-to-date.

@ahinzmann
Copy link
Contributor

It is up-to-date in terms of algorithms and code in CMSSW and we should be keep it like this for test.
However, the user interface (using python functions rather than a simple config) develops.

@slava77
Copy link
Contributor

slava77 commented May 27, 2015

OK, so this PR should be updated then, renaming the file to testJetTools_cfg.py, right?

@slava77
Copy link
Contributor

slava77 commented May 27, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

Pull request #9291 was updated. @cmsbuild, @cvuosalo, @nclopezo, @slava77 can you please check and sign again.

@cmsbuild
Copy link
Contributor

@cvuosalo
Copy link
Contributor

+1

For #9291 05acff6

Renaming file to reflect that its package has become stand-alone. No changes to standard workflows should occur.

Jenkins tests against baseline CMSSW_7_5_X_2015-05-26-2300 show no significant differences, as expected.

@cvuosalo
Copy link
Contributor

@alefisico: Please revise the title of this PR to reflect the fact that the file is being renamed, not removed.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @smuzaffar

@alefisico alefisico changed the title removing jettoolbox from CMSSW rename jettoolbox_cfg.py to testJettools_cfg.py to avoid confusion May 28, 2015
@davidlange6
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants