New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rename jettoolbox_cfg.py to testJettools_cfg.py to avoid confusion #9291
rename jettoolbox_cfg.py to testJettools_cfg.py to avoid confusion #9291
Conversation
A new Pull Request was created by @alefisico (Alejandro Gomez Espinosa) for CMSSW_7_5_X. removing jettoolbox from CMSSW It involves the following packages: RecoJets/JetProducers @cmsbuild, @cvuosalo, @nclopezo, @slava77 can you please review it and eventually sign? Thanks. |
this was a good test file to check jet-related algorithms not included in standard workflows. |
The motivation to remove it from the release it is that it is outdated and causes confusion, while a better version is in the works. |
What prevents you from having this file more up to date with the release? |
It is up-to-date in terms of algorithms and code in CMSSW and we should be keep it like this for test. |
OK, so this PR should be updated then, renaming the file to testJetTools_cfg.py, right? |
@cmsbuild please test |
The tests are being triggered in jenkins. |
@alefisico: Please revise the title of this PR to reflect the fact that the file is being renamed, not removed. |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @smuzaffar |
+1 |
rename jettoolbox_cfg.py to testJettools_cfg.py to avoid confusion
New version is a stand-alone package here: https://github.com/cms-jet/JetToolbox