Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

back port of #9073 for 74x #9322

Merged
merged 4 commits into from Jun 10, 2015
Merged

Conversation

VinInn
Copy link
Contributor

@VinInn VinInn commented May 28, 2015

back port is requested to make T&P efficiency computation possible with first data

please refer to #9073 and corresponding presentation to reco-meeting for details

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @VinInn (Vincenzo Innocente) for CMSSW_7_4_X.

back port of #9073 for 74x

It involves the following packages:

DataFormats/GsfTrackReco
DataFormats/TrackReco
RecoTracker/FinalTrackSelectors
SimTracker/TrackAssociation

@civanch, @nclopezo, @cvuosalo, @mdhildreth, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@ghellwig, @makortel, @abbiendi, @GiacomoSguazzoni, @jhgoh, @VinInn, @appeltel, @mschrode, @rovere, @gpetruc, @cerati, @threus, @dgulhan, @venturia this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@slava77
Copy link
Contributor

slava77 commented May 28, 2015

Hi Vincenzo,
Is this the version with the trackpriority untouched?
We should not really change physics performance (even in that minor way) in tracking in 74X.

@VinInn
Copy link
Contributor Author

VinInn commented May 28, 2015

On 28 May, 2015, at 6:51 PM, Slava Krutelyov notifications@github.com wrote:

Hi Vincenzo,
Is this the version with the trackpriority untouched?
yes, back as it was
We should not really change physics performance (even in that minor way) in tracking in 74X.

@slava77
Copy link
Contributor

slava77 commented May 29, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

-1
Tested at: f808b85
The relvals timed out after 2 hours.

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9322/2558/summary.html

@civanch
Copy link
Contributor

civanch commented Jun 6, 2015

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 6, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants