Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added scripts for on-the-fly log file compression and reading. #9332

Merged
merged 2 commits into from Jun 9, 2015

Conversation

dmitrijus
Copy link
Contributor

Added scripts for on-the-fly log file compression (ztee.py) and reading (ztail.py).

DQMMonitoringService now outputs per-ls stats, improved event rate calculation.

Refactored esMonitoring.py to pass environment variable (including GZIP_LOG).
And added on-fly-compression option.

I had to remove -Werror=unused-variable, otherwise build fails for this package:
there is an unused variable in boost include.

…ng (ztail.py).

DQMMonitoringService now outputs per-ls stats, improved event rate calculation.

Refactored esMonitoring.py to pass environment variable (including GZIP_LOG).
Now with sockets!

I had to remove -Werror=unused-variable, otherwise build fails for this package:
there is an unused variable in boost include.
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @dmitrijus (Dmitrijus) for CMSSW_7_4_X.

Added scripts for on-the-fly log file compression and reading.

It involves the following packages:

DQMServices/StreamerIO

@cmsbuild, @danduggan, @nclopezo, @deguio can you please review it and eventually sign? Thanks.
@barvic this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@deguio
Copy link
Contributor

deguio commented May 29, 2015

I know this one was tested on the DQM playback at P5.
was it submitted for 75 as well?

@dmitrijus
Copy link
Contributor Author

I will make port to 75 after we finish migration at P5.

@ghost
Copy link

ghost commented Jun 1, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 1, 2015

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 1, 2015

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 4, 2015

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9332/10023/summary.html

There are some workflows for which there are errors in the baseline:
50202.0 step 3
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 4, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@@ -8,4 +8,5 @@

<library file="*.cc" name="DQMServicesStreamerIOPlugins">
<flags EDM_PLUGIN="1"/>
<flags REM_CXXFLAGS="-Werror=unused-variable"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dmitrijus - why is this needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi David,

because otherwise the build fails in a boost include:
/opt/offline/slc6_amd64_gcc491/external/boost/1.51.0-cms2/include/boost/asio/error.hpp:244:45: error: 'boost::asio::error::system_category' defined but not used [-Werror=unused-variable]
static const boost::system::error_category& system_category

Dmitrijus

@davidlange6
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants