Add missing GCC11_OVERRIDE / override

[davidlt]

Clang pre-3.7 throws a warning for any missing override if override
is used at least once in a class thus enforsing to be consistent.

Resolves dozens of warnings in ROOT 6.04.00.

Signed-off-by: David Abdurachmanov David.Abdurachmanov@cern.ch

[cmsbuild]

A new Pull Request was created by @davidlt for CMSSW_7_5_X.

Add missing GCC11_OVERRIDE / override

It involves the following packages:

DataFormats/Common
DataFormats/TrackerRecHit2D
DataFormats/TrackingRecHit
TrackingTools/TrajectoryState

@cmsbuild, @cvuosalo, @Dr15Jones, @slava77 can you please review it and eventually sign? Thanks.
@battibass, @makortel, @wmtan, @abbiendi, @GiacomoSguazzoni, @wddgit, @VinInn, @appeltel, @bellan, @jhgoh, @gpetruc, @cerati, @rovere, @trocino, @dgulhan, @venturia this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.

[Dr15Jones]

+1

[cmsbuild]

-1

Tested at: d1b009d
I found errors in the following unit tests:

---> test runtestTqafTopEventProducers had ERRORS
---> test runtestTqafTopTools had ERRORS
---> test runtestTqafExamples had ERRORS
---> test TestFWCoreIntegrationStandalone had ERRORS

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9353/5354/summary.html

[cvuosalo]

+1

For #9353 d1b009d

Adding GCC11_OVERRIDE identifiers to silence Clang warnings for ROOT 6.04. This change should not change program behavior. Some Clang override warnings from other files still remain.

The code changes are satisfactory, and Jenkins tests against baseline CMSSW_7_5_X_2015-05-29-2300 show no significant differences, as expected. There were problems with Jenkins unit tests, but they are unrelated to this PR.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes (but tests are reportedly failing). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

[cmsbuild]

-1

Tested at: d1b009d
I found errors in the following unit tests:

---> test TestFWCoreIntegrationStandalone had ERRORS

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9353/5183/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9353/5183/summary.html

[davidlt]

Failing unit test is not related and should be fixed in 30-2300 IB.