New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CondFormats/ESObjects: dictionary cleanup #9358
CondFormats/ESObjects: dictionary cleanup #9358
Conversation
Thanks to Danilo ROOT 6.04.00 will have user-friendly duplicate check on a dictionary generation. The patch fixes a typo for `ESAngleCorrectionFactors` typedef based on how `ESIntercalibConstants.h` is structured. The end type does not change. Fixes the following warning: Warning: Selection file classes_def.xml, lines 28 and 26. Attempt to select with a named selection rule an already selected class. The name used in the selection is "ESAngleCorrectionFactors" while the class is "ESCondObjectContainer". `ESIntercalibConstants` and `ESAngleCorrectionFactors` are both `ESCondObjectContainer<float>`. Tested by comparing `seal_cap.cc`, which does not change after this patchset. Signed-off-by: David Abdurachmanov <David.Abdurachmanov@cern.ch>
A new Pull Request was created by @davidlt for CMSSW_7_5_X. CondFormats/ESObjects: dictionary cleanup It involves the following packages: CondFormats/ESObjects @ggovi, @cmsbuild, @mmusich, @diguida, @cerminar can you please review it and eventually sign? Thanks. |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
+1 |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
+1 |
CondFormats/ESObjects: dictionary cleanup
Thanks to Danilo ROOT 6.04.00 will have user-friendly duplicate check on
a dictionary generation.
The patch fixes a typo for
ESAngleCorrectionFactors
typedef based onhow
ESIntercalibConstants.h
is structured. The end type does notchange.
Fixes the following warning:
ESIntercalibConstants
andESAngleCorrectionFactors
are bothESCondObjectContainer<float>
.Tested by comparing
seal_cap.cc
, which does not change after thispatchset.
Signed-off-by: David Abdurachmanov David.Abdurachmanov@cern.ch