DataFormats/RecoCandidate: clean dictionary of duplicate selection rules

[davidlt]

Thanks to Danilo ROOT 6.04.00 will have user-friendly duplicate
selection rule check.

Warning: Selection file classes_def.xml, lines 143 and 89. Attempt to
select with a named selection rule an already selected class. The name
used in the selection is "reco::IsoDepositMap" while the class is
"edm::ValueMap<reco::IsoDeposit>".

Tested by comparing seal_cap.cc, which does not change after this
patchset.

Signed-off-by: David Abdurachmanov David.Abdurachmanov@cern.ch

[cmsbuild]

A new Pull Request was created by @davidlt for CMSSW_7_5_X.

DataFormats/RecoCandidate: clean dictionary of duplicate selection rules

It involves the following packages:

DataFormats/RecoCandidate

@cmsbuild, @cvuosalo, @slava77 can you please review it and eventually sign? Thanks.
@makortel this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[davidlt]

Notice, that there are rules which select nothing:

Warning - unused class rule: edm::RefVector<edm::AssociationMap<*>
Warning - unused class rule: edm::RefProd<edm::AssociationMap<*>
Warning - unused class rule: edm::Ref<edm::AssociationMap<*>
Warning - unused class rule: edm::KeyVal<*>

They should be reviewed and removed if not needed. There are no such types in translation unit. Thus either to remove the rules or modify classes.h to have wanted types.

[cmsbuild]

+1
Tested at: 10ed53c
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9363/5187/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9363/5187/summary.html