Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataFormats/PatCandidates: add missing class #9375

Closed

Conversation

davidlt
Copy link
Contributor

@davidlt davidlt commented May 31, 2015

While building CMSSW the following warning is generated by ROOT6
run-time:

TClass::Init:0: RuntimeWarning: no dictionary for class
edm::AtomicPtrCache<vector<edm::Ptr<CaloTower> > > is available

Add missing class edm::AtomicPtrCache<vector<edm::Ptr<CaloTower> > >

Signed-off-by: David Abdurachmanov David.Abdurachmanov@cern.ch

While building CMSSW the following warning is generated by ROOT6
run-time:

    TClass::Init:0: RuntimeWarning: no dictionary for class
    edm::AtomicPtrCache<vector<edm::Ptr<CaloTower> > > is available

Add missing class `edm::AtomicPtrCache<vector<edm::Ptr<CaloTower> > >`

Signed-off-by: David Abdurachmanov <David.Abdurachmanov@cern.ch>
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @davidlt for CMSSW_7_5_X.

DataFormats/PatCandidates: add missing class

It involves the following packages:

DataFormats/PatCandidates

@cmsbuild, @vadler, @monttj can you please review it and eventually sign? Thanks.
@gpetruc this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@Dr15Jones
Copy link
Contributor

hold

@Dr15Jones
Copy link
Contributor

The dictionaries actually belong in DataFormats/CaloTower

@cmsbuild
Copy link
Contributor

@davidlt
Copy link
Contributor Author

davidlt commented May 31, 2015

All edm::AtomicPtrCache are defined in this dictionary and used only by this dictionary. IIRC, there are other *Calo* defined in this same dictionary.

@Dr15Jones
Copy link
Contributor

If so, then these dictionaries are in the wrong library. If these edm::AtomicPtrCache are ever used by another class then it would require the library to link to this library which makes for bad dependencies.

@cmsbuild
Copy link
Contributor

@davidlt
Copy link
Contributor Author

davidlt commented May 31, 2015

I will take care of that tomorrow.

@davidlt
Copy link
Contributor Author

davidlt commented Jun 1, 2015

Replaced by #9380

@davidlt davidlt closed this Jun 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants