Fix out of bound array in photon uncertainty calculation

[rafaellopesdesa]

Old photon uncertainty calculation was trying to access array index -1.
Added protection against that.

This modification concerns only an outdated energy correction that should not be used anymore. Thus, this should not affect any current usage of RecoEgamma.

[slava77]

@Degano please check if the bot is still awake. This PR wasn't announced and labelled yet.

[cmsbuild]

A new Pull Request was created by @rafaellopesdesa (Rafael Lopes de Sa) for CMSSW_7_5_X.

Fix out of bound array in photon uncertainty calculation

It involves the following packages:

RecoEgamma/EgammaPhotonAlgos

@cmsbuild, @cvuosalo, @slava77 can you please review it and eventually sign? Thanks.
@Sam-Harper, @lgray this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[cmsbuild]

-1
Tested at: 00b9c90
The relvals timed out after 2 hours.

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9381/5210/summary.html

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.

[cvuosalo]

+1

For #9381 1ccf013

Protect against incorrect array reference used to calculate photon uncertainty.

The code changes are satisfactory, and Jenkins tests against baseline CMSSW_7_5_X_2015-06-22-2300 show no significant differences, except for workflow 50202.0_TTbar_13+TTbar_13+DIGIUP15_PU50 where the fix appears to correct an outlier photon uncertainty value:

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs once checked with relvals in the development release cycle of CMSSW (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

[davidlange6]

+1

[slava77]

@rafaellopesdesa @lgray
please make similar fixes in RecoEgamma/EgammaElectronAlgos/src/EnergyUncertaintyElectronSpecific.cc as well
this is related to still open issue
slava77#4 (first reported to Egamma on July 30, 2013)