Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate tp emulator parameters for HF. #9388

Merged

Conversation

akhukhun
Copy link
Contributor

@akhukhun akhukhun commented Jun 1, 2015

A small modification to the Hcal TP emulator to pass the “presamples" and “samples” separately for HF.
This will allow emulating TPs with different values of these parameters for HBHE and HF (which is the case now).
The default values in the configuration file stay the same.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 1, 2015

A new Pull Request was created by @akhukhun for CMSSW_7_5_X.

Separate tp emulator parameters for HF.

It involves the following packages:

SimCalorimetry/HcalTrigPrimAlgos
SimCalorimetry/HcalTrigPrimProducers

@cmsbuild, @mulhearn can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@mulhearn
Copy link
Contributor

mulhearn commented Jun 3, 2015

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 3, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 3, 2015

-1
Tested at: 44cfbf2
When I ran the RelVals I found an error in the following worklfows:
25202.0 step3

runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25+MINIAODMCUP15/step3_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25+MINIAODMCUP15.log
----- Begin Fatal Exception 03-Jun-2015 20:04:39 CEST-----------------------
An exception of category 'Configuration' occurred while
   [0] Processing run: 1 lumi: 1 event: 1
   [1] Running path 'validation_step'
   [2] Calling event method for module MixingModule/'mix'
Exception Message:
RootInputFileSequence::readOneSpecified(): no input files specified for secondary input source.
----- End Fatal Exception -------------------------------------------------

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9388/8023/summary.html

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 3, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes (but tests are reportedly failing). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

davidlange6 added a commit that referenced this pull request Jun 4, 2015
Separate tp emulator parameters for HF.
@davidlange6 davidlange6 merged commit 7212aee into cms-sw:CMSSW_7_5_X Jun 4, 2015
@akhukhun akhukhun deleted the hcal-tp-emul-addhfparams-75 branch February 22, 2018 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants