Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn on track selection MVA in Heavy Ions #9391

Merged
merged 1 commit into from Jun 8, 2015

Conversation

istaslis
Copy link
Contributor

@istaslis istaslis commented Jun 1, 2015

Turn on track selection MVA in Heavy Ions after payloads have been uploaded and conditions have been updated.
@mandrenguyen @yetkinyilmaz @VinInn

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 1, 2015

A new Pull Request was created by @istaslis (Stas Lisniak) for CMSSW_7_5_X.

Turn on track selection MVA in Heavy Ions

It involves the following packages:

RecoHI/HiTracking

@cmsbuild, @cvuosalo, @slava77 can you please review it and eventually sign? Thanks.
@echapon, @jazzitup, @dgulhan, @appeltel, @yenjie, @kurtejung, @mandrenguyen, @richard-cms, @yetkinyilmaz this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@slava77
Copy link
Contributor

slava77 commented Jun 1, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 1, 2015

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 1, 2015

@cvuosalo
Copy link
Contributor

cvuosalo commented Jun 7, 2015

+1

For #9391 519d275

For Heavy Ions, track selection via MVA is enabled.

The code changes are satisfactory. Jenkins tests show no significant differences for all workflows except for RunHI2011wf140p53, as expected. Extended tests for workflows HydjetQ_MinBias_2760GeVwf140p0 and RunHI2011wf140p53 against baseline CMSSW_7_5_X_2015-06-01-110 using 100 events show extensive changes as expected for the change in track selection (see below).
Disk size of reco products changes marginally. The number of tracks increase by about 1-2%, but the resulting size of PF candidates decrease by roughly 5%.
CPU timing appears to improve somewhat. Selector times increase roughly 2-5 times, but amounting to only several ms/event, while PF times are reduced considerably by 5-25%, amounting to 50-400 ms/event (depending on workflow details), and seeming to result in a small net reduction in CPU time.

wf HydjetQ_MinBias_2760GeVwf140p0
effic140p0
effvseta
efvshits
fakerate140p0
fakevsdr
rechits140p0
all_testpr9391vsorig_hydjetq_minbias_2760gevwf140p0c_log10recopfjets_akvs4pfjets__reco_obj_energy
all_testpr9391vsorig_hydjetq_minbias_2760gevwf140p0c_log10recotracks_higeneraltracks__reco_obj_pt
all_testpr9391vsorig_hydjetq_minbias_2760gevwf140p0c_recotracks_higeneraltracks__reco_obj_eta

wf RunHI2011wf140p53
effvseta
etahipur
all_testpr9391vsorig_runhi2011wf140p53c_log10recotracks_higeneraltracks__rereco_obj_pt
all_testpr9391vsorig_runhi2011wf140p53c_recotracks_higeneraltracks__rereco_obj_eta

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 7, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants