New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix to allow histogram rebinning to work again for Tracker DQM trend plots in ROOT6 #9400
Conversation
…d(TH1::kAllAxes) in DQM SiStrip/Tracking code so that histogram rebinning can work with ROOT6
A new Pull Request was created by @vdutta (Valentina Dutta) for CMSSW_7_4_X. Fix to allow histogram rebinning to work again for Tracker DQM trend plots in ROOT6 It involves the following packages: DQM/SiStripMonitorCluster @cmsbuild, @danduggan, @deguio can you please review it and eventually sign? Thanks. |
+1 |
please test |
The tests are being triggered in jenkins. |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
If this PR could merged and put in production at T0 (and online) it would be very useful. As long as it is not there some Tracker DQM plots are broken. |
@venturia, at least for online DQM, you've already got this in. this PR was included as of this past Tuesday evening. |
Thanks! @venturiahttps://github.com/venturia, at least for online DQM, you've already got this in. this PR was included as of this past Tuesday evening. — |
+1 |
Fix to allow histogram rebinning to work again for Tracker DQM trend plots in ROOT6
In ROOT6 the TH1 kCanRebin option doesn't work anymore. This affects the behavior of the current tracker DQM trend plots. They are no longer correctly updated to accommodate an expanded histogram axis to show trends vs lumi section for longer runs for example, since the histograms can no longer be rebinned. This fix updates the use of the SetBit(kCanRebin) option to SetCanExtend(TH1::kAllAxes) as recommended for ROOT6 in the Tracker DQM code and is needed quite urgently to restore the correct behavior for the trend plots. Also, the code for DQMRootSource (DQMServices/FwkIO/plugins/DQMRootSource.cc) is updated for the merging of rebinnable histograms during harvesting to be compatible with the new ROOT6 behavior (the old TestBit(TH1::kCanRebin) is replaced with the new CanExtendAllAxes()).