Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to allow histogram rebinning to work again for Tracker DQM trend plots in ROOT6 #9400

Merged
merged 3 commits into from Jun 10, 2015

Conversation

vdutta
Copy link
Contributor

@vdutta vdutta commented Jun 2, 2015

In ROOT6 the TH1 kCanRebin option doesn't work anymore. This affects the behavior of the current tracker DQM trend plots. They are no longer correctly updated to accommodate an expanded histogram axis to show trends vs lumi section for longer runs for example, since the histograms can no longer be rebinned. This fix updates the use of the SetBit(kCanRebin) option to SetCanExtend(TH1::kAllAxes) as recommended for ROOT6 in the Tracker DQM code and is needed quite urgently to restore the correct behavior for the trend plots. Also, the code for DQMRootSource (DQMServices/FwkIO/plugins/DQMRootSource.cc) is updated for the merging of rebinnable histograms during harvesting to be compatible with the new ROOT6 behavior (the old TestBit(TH1::kCanRebin) is replaced with the new CanExtendAllAxes()).

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 2, 2015

A new Pull Request was created by @vdutta (Valentina Dutta) for CMSSW_7_4_X.

Fix to allow histogram rebinning to work again for Tracker DQM trend plots in ROOT6

It involves the following packages:

DQM/SiStripMonitorCluster
DQM/SiStripMonitorDigi
DQM/SiStripMonitorHardware
DQM/SiStripMonitorTrack
DQM/TrackingMonitor
DQMServices/FwkIO

@cmsbuild, @danduggan, @deguio can you please review it and eventually sign? Thanks.
@makortel, @barvic, @threus, @venturia this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@deguio
Copy link
Contributor

deguio commented Jun 2, 2015

+1

@deguio
Copy link
Contributor

deguio commented Jun 2, 2015

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 2, 2015

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 2, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 2, 2015

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 2, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@venturia
Copy link
Contributor

venturia commented Jun 7, 2015

If this PR could merged and put in production at T0 (and online) it would be very useful. As long as it is not there some Tracker DQM plots are broken.

@danduggan
Copy link
Contributor

@venturia, at least for online DQM, you've already got this in. this PR was included as of this past Tuesday evening.

@venturia
Copy link
Contributor

venturia commented Jun 7, 2015

Thanks!
On Jun 7, 2015, at 11:37 , danduggan <notifications@github.commailto:notifications@github.com>
wrote:

@venturiahttps://github.com/venturia, at least for online DQM, you've already got this in. this PR was included as of this past Tuesday evening.


Reply to this email directly or view it on GitHubhttps://github.com//pull/9400#issuecomment-109729801.

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Jun 10, 2015
Fix to allow histogram rebinning to work again for Tracker DQM trend plots in ROOT6
@cmsbuild cmsbuild merged commit 4e162a2 into cms-sw:CMSSW_7_4_X Jun 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants