Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PhysicsTools/IsolationAlgos: add missing dependecy on DataFormats/PatCandidates #9442

Merged
merged 1 commit into from Jun 6, 2015
Merged

PhysicsTools/IsolationAlgos: add missing dependecy on DataFormats/PatCandidates #9442

merged 1 commit into from Jun 6, 2015

Conversation

davidlt
Copy link
Contributor

@davidlt davidlt commented Jun 4, 2015

The plugin is failing to build on CMSSW_7_5_X/AArch64:

PhysicsToolsIsolationAlgos_plugins/CITKPFIsolationSumProducer.o: In function 'citk::PFIsolationSumProducer::produce(edm::Event&, edm::EventSetup const&)':
CITKPFIsolationSumProducer.cc:(.text+0x186c): undefined reference to 'pat::PackedCandidate::unpack() const'
PhysicsToolsIsolationAlgos_plugins/CITKPFIsolationSumProducer.o: In function 'pat::PackedCandidate::pt() const':
CITKPFIsolationSumProducer.cc:(.text._ZNK3pat15PackedCandidate2ptEv[_ZNK3pat15PackedCandidate2ptEv]+0x18): undefined reference to 'pat::PackedCandidate::unpack() const'

According to LXR pat::PackedCandidate is used in 3 files.

http://cmslxr.fnal.gov/ident?v=CMSSW_7_5_X_2015-06-02-2300&_i=PackedCandidate&_remember=1

LXR link should explain everything.

Signed-off-by: David Abdurachmanov David.Abdurachmanov@cern.ch

PhysicsTools/IsolationAlgos: add missing dependecy on DataFormats/Pat…
c16cdb7 
…Candidates

The plugin is failing to build on CMSSW_7_5_X/AArch64:

    PhysicsToolsIsolationAlgos_plugins/CITKPFIsolationSumProducer.o: In function 'citk::PFIsolationSumProducer::produce(edm::Event&, edm::EventSetup const&)':
    CITKPFIsolationSumProducer.cc:(.text+0x186c): undefined reference to 'pat::PackedCandidate::unpack() const'
    PhysicsToolsIsolationAlgos_plugins/CITKPFIsolationSumProducer.o: In function 'pat::PackedCandidate::pt() const':
    CITKPFIsolationSumProducer.cc:(.text._ZNK3pat15PackedCandidate2ptEv[_ZNK3pat15PackedCandidate2ptEv]+0x18): undefined reference to 'pat::PackedCandidate::unpack() const'

According to LXR `pat::PackedCandidate` is used in 3 files.

http://cmslxr.fnal.gov/ident?v=CMSSW_7_5_X_2015-06-02-2300&_i=PackedCandidate&_remember=1

Signed-off-by: David Abdurachmanov <David.Abdurachmanov@cern.ch>
@cmsbuild cmsbuild added this to the Next CMSSW_7_5_X milestone Jun 4, 2015
@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 4, 2015

A new Pull Request was created by @davidlt for CMSSW_7_5_X.

PhysicsTools/IsolationAlgos: add missing dependecy on DataFormats/PatCandidates

It involves the following packages:

PhysicsTools/IsolationAlgos

@cmsbuild, @vadler, @monttj can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 4, 2015

-1
Tested at: c16cdb7
When I ran the RelVals I found an error in the following worklfows:
25202.0 step2

runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25+MINIAODMCUP15/step2_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25+MINIAODMCUP15.log
----- Begin Fatal Exception 04-Jun-2015 11:44:25 CEST-----------------------
An exception of category 'Configuration' occurred while
   [0] Processing run: 1 lumi: 1 event: 1
   [1] Running path 'digitisation_step'
   [2] Calling event method for module MixingModule/'mix'
Exception Message:
RootInputFileSequence::readOneRandom(): no input files specified for secondary input source.
----- End Fatal Exception -------------------------------------------------

50202.0 step2

runTheMatrix-results/50202.0_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50+MINIAODMCUP1550/step2_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50+MINIAODMCUP1550.log
----- Begin Fatal Exception 04-Jun-2015 11:44:30 CEST-----------------------
An exception of category 'Configuration' occurred while
   [0] Processing run: 1 lumi: 1 event: 1
   [1] Running path 'digitisation_step'
   [2] Calling event method for module MixingModule/'mix'
Exception Message:
RootInputFileSequence::readOneRandom(): no input files specified for secondary input source.
----- End Fatal Exception -------------------------------------------------

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9442/5275/summary.html

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 4, 2015

+1
Tested at: c16cdb7
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9442/5307/summary.html

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 4, 2015

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9442/5307/summary.html

davidlange6 added a commit that referenced this pull request Jun 6, 2015
@davidlange6
Merge pull request #9442 from davidlt/fix-dep-pat
5ec6494 
PhysicsTools/IsolationAlgos: add missing dependecy on DataFormats/PatCandidates
@davidlange6 davidlange6 merged commit 5ec6494 into cms-sw:CMSSW_7_5_X Jun 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
analysis-pending comparison-available orp-pending pending-signatures tests-approved
Projects
None yet
Milestone
CMSSW_7_5_X
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@davidlt @cmsbuild @davidlange6