Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge TrackerLayerIdAccessor to TrackerTopology #9449

Merged

Conversation

makortel
Copy link
Contributor

@makortel makortel commented Jun 4, 2015

Migrate TrackerLayerIdAccessor to TrackerTopology by moving its functionality to TrackerTopology (following the suggestion of @venturia).

Tested in CMSSW_7_5_0_pre5, no changes expected in results.

@rovere @VinInn @venturia @boudoul

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 4, 2015

A new Pull Request was created by @makortel (Matti Kortelainen) for CMSSW_7_5_X.

Merge TrackerLayerIdAccessor to TrackerTopology

It involves the following packages:

DataFormats/TrackerCommon
Geometry/TrackerGeometryBuilder
RecoHI/HiTracking
RecoPixelVertexing/PixelTriplets
RecoTracker/TkHitPairs
RecoTracker/TkSeedingLayers

@civanch, @Dr15Jones, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@ghellwig, @echapon, @GiacomoSguazzoni, @jazzitup, @VinInn, @appeltel, @mschrode, @richard-cms, @yenjie, @rovere, @kurtejung, @gpetruc, @cerati, @yetkinyilmaz, @mandrenguyen, @dgulhan, @venturia this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@slava77
Copy link
Contributor

slava77 commented Jun 4, 2015

@cmsbuild please test
(matrix tests will likely fail due to das problems)

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 4, 2015

The tests are being triggered in jenkins.

@slava77
Copy link
Contributor

slava77 commented Jun 8, 2015

@ianna
Hi Yana,
this is waiting for geometry signature.
Please check.
Thank you.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 8, 2015

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 9, 2015

davidlange6 added a commit that referenced this pull request Jun 11, 2015
…ccessor

Merge TrackerLayerIdAccessor to TrackerTopology
@davidlange6 davidlange6 merged commit 6bdd448 into cms-sw:CMSSW_7_5_X Jun 11, 2015
@makortel makortel deleted the trackerTopologyTrackerLayerIdAccessor branch October 20, 2016 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants