Multithreaded fixes -- Remove more statics. #946
Conversation
|
A new Pull Request was created by @ktf (Giulio Eulisse) for CMSSW_7_0_X. Multithreaded fixes -- Remove more statics. It involves the following packages: DetectorDescription/Core @smuzaffar, @civanch, @Dr15Jones, @ianna, @mdhildreth, @nclopezo, @ktf can you please review it and eventually sign? Thanks. |
| @@ -73,14 +75,11 @@ | |||
| DDRotation::DDRotation(DDRotationMatrix * rot) | |||
| : DDBase<DDName,DDRotationMatrix*>() | |||
| { | |||
| static std::string baseNoName("DdNoNa"); | |||
There was a problem hiding this comment.
I think, I'd prefer using:
constexpr char const* baseNoName = "DdNoNa";
and replace the string on lines 80 and 81
There was a problem hiding this comment.
But lines 80 and 81 have different strings "DdNoNa" and "DdNoNa%i".
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @ktf can you please take care of it? |
Multithreaded fixes -- Remove more statics.
No description provided.