Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CondFormats/Alignment: remove unused selection rules #9507

Merged
merged 1 commit into from Jun 8, 2015
Merged

CondFormats/Alignment: remove unused selection rules #9507

merged 1 commit into from Jun 8, 2015

Conversation

davidlt
Copy link
Contributor

@davidlt davidlt commented Jun 8, 2015

The int32_t is not selecting anything in ROOT5 and ROOT6.

No changes to types in dictionaries found after removing on ROOT5 and
ROOT6.

Resolves:

Warning - unused class rule: uint32_t

Signed-off-by: David Abdurachmanov David.Abdurachmanov@cern.ch

CondFormats/Alignment: remove unused selection rules
ad3a0e3 
The `int32_t` is not selecting anything in ROOT5 and ROOT6.

No changes to types in dictionaries found after removing on ROOT5 and
ROOT6.

Signed-off-by: David Abdurachmanov <David.Abdurachmanov@cern.ch>
@cmsbuild cmsbuild added this to the Next CMSSW_7_5_X milestone Jun 8, 2015
@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 8, 2015

A new Pull Request was created by @davidlt for CMSSW_7_5_X.

CondFormats/Alignment: remove unused selection rules

It involves the following packages:

CondFormats/Alignment

@ggovi, @cmsbuild, @mmusich, @diguida, @cerminar can you please review it and eventually sign? Thanks.
@apfeiffer1 this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@mmusich
Copy link
Contributor

mmusich commented Jun 8, 2015

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 8, 2015

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 8, 2015

+1
Tested at: ad3a0e3
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9507/10129/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
9a9f988
d78a36b
ab71347
4ef6d59
1d937ec
8fde817
ff163e2
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9507/10129/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9507/10129/git-merge-result

davidlange6 added a commit that referenced this pull request Jun 8, 2015
@davidlange6
Merge pull request #9507 from davidlt/clean-unused-select-rules-CondF…
1645420 
…ormats-Alignment

CondFormats/Alignment: remove unused selection rules
@davidlange6 davidlange6 merged commit 1645420 into cms-sw:CMSSW_7_5_X Jun 8, 2015
@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 8, 2015

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9507/10129/summary.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
alca-pending comparison-pending db-pending orp-pending pending-signatures tests-approved
Projects
None yet
Milestone
CMSSW_7_5_X
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@davidlt @cmsbuild @mmusich @davidlange6