Multithreaded TriggerNamesService

[wddgit]

Make the TriggerNamesService run with the multithreaded
Framework. Made one non thread safe function private instead
of public.

[cmsbuild]

A new Pull Request was created by @wddgit for CMSSW_7_0_X.

Multithreaded TriggerNamesService

It involves the following packages:

FWCore/Framework

@smuzaffar, @Dr15Jones, @ktf, @nclopezo can you please review it and eventually sign? Thanks.
@wmtan this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@ktf you are the release manager for this.

[Dr15Jones]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @ktf can you please take care of it?

[nclopezo]

-1
When I ran the Jenkins tests I got a segmentation violation error on the unit test TestIntegrationRunMerge:

A fatal system signal has occurred: segmentation violation
/build/cmsbuild/jenkins-workarea/workspace/Pull-Request-Integration/ARCHITECTURE/slc5_amd64_gcc481/CMSSW_7_0_X_2013-10-01-0200/src/FWCore/Integration/test/run_RunMerge.sh: line 71: 18017 Aborted                 cmsRun -p ${LOCAL_TEST_DIR}/${test}TEST1_cfg.py
Failure cmsRun testRunMergeTEST1_cfg.py: status 134
status = 34304

You can see the complete logs here:

https://cmssdt.cern.ch/jenkins/job/Pull-Request-Integration/ARCHITECTURE=slc5_amd64_gcc481/706/console
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/706

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @ktf can you please take care of it?

[Dr15Jones]

I don't believe this failure has anything to do with this pull request. This commit only changed a public method to be a private method. The actual failure I seen in the Jenkins report was a seg fault in an unrelated area of the code, i.e. the JobReport which was changed in an earlier pull request.
@wddgit David, could you look into the crash to see how it might have happened?

[wddgit]

I found the bug causing the crash. It is actually in
#905 that was merged on the 27th (last Friday).
It would affect jobs that have both a job report
and secondary file input.

I have a fix and am testing it now. I'll submit it as
a separate pull request.

#952 should be OK as is, although you may want to
wait for the bug fix so you can run the tests.

Regards
David Dagenhart

On 10/01/2013 04:32 AM, David Mendez wrote:

-1
When I ran the Jenkins tests I got a segmentation violation error on
the unit test TestIntegrationRunMerge:

A fatal system signal has occurred: segmentation violation
/build/cmsbuild/jenkins-workarea/workspace/Pull-Request-Integration/ARCHITECTURE/slc5_amd64_gcc481/CMSSW_7_0_X_2013-10-01-0200/src/FWCore/Integration/test/run_RunMerge.sh: line 71: 18017 Aborted cmsRun -p ${LOCAL_TEST_DIR}/${test}TEST1_cfg.py
Failure cmsRun testRunMergeTEST1_cfg.py: status 134
status = 34304

You can see the complete logs here:

https://cmssdt.cern.ch/jenkins/job/Pull-Request-Integration/ARCHITECTURE=slc5_amd64_gcc481/706/console
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/706

—
Reply to this email directly or view it on GitHub
#952 (comment).

[wddgit]

Revision to the previous comment. The bug could actually affect any job with secondary file input. The JobReport code executes even when it is not configured to print anything out.

[nclopezo]

+1
I tested #952 and #966 together here:
https://cmssdt.cern.ch/jenkins/job/Pull-Request-Integration/ARCHITECTURE=slc5_amd64_gcc481/733/console
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/733/build.log
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/733/unitTests.log
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/733/runTheMatrix-results

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @ktf can you please take care of it?