Turn off calo muons in HI reco sequence

[mandrenguyen]

Removing calo muons saves about 1/3 of the time of the total muon sequence in central PbPb events, as discussed with @echapon

The following code had been commented out:
-# turn off calo muons for timing considerations?
-#muons.fillCaloCompatibility = cms.bool(False)

but activating this didn't change the timing at all, so minPCaloMuon was set to a very large number instead, as done at the HLT.

@trocino @battibass, can you confirm that this is the preferred way to do this?

[cmsbuild]

A new Pull Request was created by @mandrenguyen for CMSSW_7_5_X.

Turn off calo muons in HI reco sequence

It involves the following packages:

RecoHI/HiMuonAlgos

@cmsbuild, @cvuosalo, @slava77 can you please review it and eventually sign? Thanks.
@echapon, @MiheeJo, @jazzitup, @richard-cms, @appeltel, @yenjie, @kurtejung, @dgulhan, @yetkinyilmaz this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.

[slava77]

@mandrenguyen @echapon
fillCaloCompatibility is not expected to take much CPU: it's just a computation of the muon likelihood variable based on already available calorimeter energy inputs; all CPU is consumed upstream.
So, your current fix is what indeed should be done.

[cmsbuild]

+1
Tested at: c8d4736
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9559/5452/summary.html

[cvuosalo]

Starting extended test...

[cvuosalo]

+1

For #9559 c8d4736

Calo muons are disabled in the HI reco sequence.
The code change is satisfactory, and Jenkins tests against baseline CMSSW_7_5_X_2015-06-11-1100 show no significant differences, except for the intended disappearance of calo muons from the validateJR plots for workflow 140.53_RunHI2011. Extended tests for this workflow against baseline CMSSW_7_5_X_2015-06-11-1100 using 100 events confirms these results and show the following 30% improvement in CPU time for the muon sequence:

muons 1880.13 ms/ev -> 1345.37 ms/ev
calomuons 0.191759 ms/ev -> 0.155932 ms/ev

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

[davidlange6]

+1