Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add checks if trajectory has hits before accessing them #9602

Merged
merged 1 commit into from Jun 14, 2015

Conversation

slava77
Copy link
Contributor

@slava77 slava77 commented Jun 12, 2015

fixes crashes in refittedStandAloneMuons observed in 750pre4 and pre5

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @slava77 (Slava Krutelyov) for CMSSW_7_5_X.

add checks if trajectory has hits before accessing them

It involves the following packages:

TrackingTools/TrackFitters

@cmsbuild, @cvuosalo, @slava77 can you please review it and eventually sign? Thanks.
@battibass, @makortel, @abbiendi, @GiacomoSguazzoni, @jhgoh, @VinInn, @appeltel, @bellan, @rovere, @cerati, @gpetruc, @istaslis, @trocino, @dgulhan, @venturia this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@slava77
Copy link
Contributor Author

slava77 commented Jun 12, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@slava77
Copy link
Contributor Author

slava77 commented Jun 12, 2015

+1

for #9602 1118cf6

  • crash reported in https://hypernews.cern.ch/HyperNews/CMS/get/relval/3728.html is fixed (the code processes the problematic event)
  • local short matrix tests were done with CMSSW_7_5_0_pre5 /test area fixMuRefit/. Comparisons with baseline show no differences as expected (the changed part of the code can possibly behave differently if the baseline was crashing, but that doesn't happen in the set of tests running).

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants