Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes to JSONMonotoring (74X) #9613

Merged
merged 3 commits into from Jun 16, 2015
Merged

Fixes to JSONMonotoring (74X) #9613

merged 3 commits into from Jun 16, 2015

Conversation

smorovic
Copy link
Contributor

  • fix calculating checksum on a wrong buffer (cause of spurious crashes)
  • suppression of output when FastMonitoringService value is reset to 0

@smorovic
*fix stat where reading from name buffer instead of content buffer wh…
f7a4a7d 
…en calculating Adler32

*suppression of output when FastMonitoringService value is reset to 0
@smorovic smorovic mentioned this pull request Jun 14, 2015
Merged
@cmsbuild cmsbuild added this to the Next CMSSW_7_4_X milestone Jun 14, 2015
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @smorovic (Srecko Morovic) for CMSSW_7_4_X.

Fixes to JSONMonotoring (74X)

It involves the following packages:

HLTrigger/JSONMonitoring

@Martin-Grunewald, @perrotta, @cmsbuild, @fwyzard can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

Pull request #9613 was updated. @Martin-Grunewald, @perrotta, @cmsbuild, @fwyzard can you please check and sign again.

fwyzard
fwyzard reviewed Jun 15, 2015
View reviewed changes
HLTrigger/JSONMonitoring/plugins/TriggerJSONMonitoring.cc
@@ -573,6 +579,14 @@ TriggerJSONMonitoring::globalEndLuminosityBlockSummary(const edm::LuminosityBloc
outHltJsnData<<result;
outHltJsnData.close();

//HLT jsn entries
StringJ hltJsnFilelist_;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi Srecko,
please do not use names ending with an underscore for non-member variables.

.A

@smorovic
* removing trailing '_' from local variables
d196a8c 
* check if MicroStaterService is available for better readability
@smorovic
Copy link
Contributor Author

@fwyzard
I changed all local variables to not use "_" (although this is Aram's code, I'm just fixing a bug...).
There is a check for the service, but I changed it a bit to be more readable.

@cmsbuild
Copy link
Contributor

Pull request #9613 was updated. @Martin-Grunewald, @perrotta, @cmsbuild, @fwyzard can you please check and sign again.

@Martin-Grunewald
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@fwyzard
Copy link
Contributor

fwyzard commented Jun 15, 2015

hi @smorovic , I was looking only at the diff, but thanks for renaming the variables elsewhere, too.

@Martin-Grunewald
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs once checked with relvals in the development release cycle of CMSSW (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Jun 16, 2015
@cmsbuild
Merge pull request #9613 from smorovic/fixes-jsonmonitoring
0fe5383 
Fixes to JSONMonotoring (74X)
@cmsbuild cmsbuild merged commit 0fe5383 into cms-sw:CMSSW_7_4_X Jun 16, 2015
@smorovic smorovic deleted the fixes-jsonmonitoring branch November 13, 2015 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-available fully-signed hlt-approved tests-approved
Projects
None yet
Milestone
Next CMSSW_7_4_X
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@smorovic @cmsbuild @Martin-Grunewald @fwyzard @davidlange6