Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc fixes -- Fix misc static analyzer issues. #962

Merged
merged 1 commit into from Oct 1, 2013
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion CondCore/DBCommon/interface/Exception.h
Expand Up @@ -31,6 +31,6 @@ namespace cond{
virtual ~TransactionException() throw(){}
};

void throwException( std::string const& message, std::string const& methodName );
void throwException( std::string const& message, std::string const& methodName )__attribute__ ((noreturn));
}
#endif
3 changes: 3 additions & 0 deletions CondCore/DBCommon/src/Cipher.cc
Expand Up @@ -5,6 +5,7 @@
#include "blowfish.h"
// GNU base 64 encoding
#include "base64.h"
#include <cassert>

cond::Cipher::Cipher( const std::string& key ):
m_ctx(new BLOWFISH_CTX){
Expand All @@ -20,6 +21,8 @@ size_t cond::Cipher::bf_process_alloc( const unsigned char* input,
size_t input_size,
unsigned char*& output,
bool decrypt ){
assert(input_size != 0);

uInt32 L, R;
unsigned int j = sizeof(uInt32);

Expand Down